From: Ani Sinha <ani@anisinha.ca>
To: qemu-devel@nongnu.org
Cc: Ani Sinha <ani@anisinha.ca>, Igor Mammedov <imammedo@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH] hw/i386/ich9: add comment explaining an argument to acpi_pcihp_reset call
Date: Tue, 27 Jul 2021 10:15:46 +0530 [thread overview]
Message-ID: <20210727044546.246363-1-ani@anisinha.ca> (raw)
acpi_pcihp_reset() call from ich9/pm_reset() passes an unconditional truth value
as the second argument. Added a commnet here to explain the reason why the
argument is being passed unconditionally.
Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
hw/acpi/ich9.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 778e27b659..b2e3c46075 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -281,6 +281,11 @@ static void pm_reset(void *opaque)
pm->smi_en_wmask = ~0;
if (pm->use_acpi_hotplug_bridge) {
+ /*
+ * PCI Express root buses do not support hot-plug, for
+ * details see docs/pcie.txt. Hence, the second argument
+ * is unconditionally true.
+ */
acpi_pcihp_reset(&pm->acpi_pci_hotplug, true);
}
--
2.25.1
next reply other threads:[~2021-07-27 4:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 4:45 Ani Sinha [this message]
2021-07-29 13:13 ` [PATCH] hw/i386/ich9: add comment explaining an argument to acpi_pcihp_reset call Ani Sinha
2021-08-03 11:34 ` Ani Sinha
2021-08-03 14:13 ` Michael S. Tsirkin
2021-08-04 13:19 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210727044546.246363-1-ani@anisinha.ca \
--to=ani@anisinha.ca \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).