From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6574AC432BE for ; Thu, 29 Jul 2021 09:55:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA99461052 for ; Thu, 29 Jul 2021 09:55:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DA99461052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m92ku-0001y1-Qm for qemu-devel@archiver.kernel.org; Thu, 29 Jul 2021 05:55:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49618) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m92k2-0001A3-KJ for qemu-devel@nongnu.org; Thu, 29 Jul 2021 05:54:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30390) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m92jy-0002HW-5M for qemu-devel@nongnu.org; Thu, 29 Jul 2021 05:54:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627552449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=skStFmpJ67QMVTtLU4r8jnmSP4g58NZlRw+HXmZLMAM=; b=JoLcIPAFllsJS6MaMhqFGtVHzTuz1QFOPaZE0laCJUkyZHKoaHuz+pLbq4KiQaj17HFpU8 4TTdmezx5KIjKMHnCCnAsEp2lIkPcv8WNrtCDXPVKDtIgNLRSvZZmYa964emLMROIVX4AI y1d+XQas2vWxpxq0f3ptJIad8h1ddvw= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-K0ZKzGN1OwSSa27W-vbxZQ-1; Thu, 29 Jul 2021 05:54:05 -0400 X-MC-Unique: K0ZKzGN1OwSSa27W-vbxZQ-1 Received: by mail-ed1-f72.google.com with SMTP id u25-20020aa7d8990000b02903bb6a903d90so2678392edq.17 for ; Thu, 29 Jul 2021 02:54:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=skStFmpJ67QMVTtLU4r8jnmSP4g58NZlRw+HXmZLMAM=; b=SlkrGrTB6oU6pgSiFGt/K8mfp1zuP6SsadttkOHAZrj6qNRMoLEGpyXP4xWTtbQAQW LmAAyYod6H1YaVtNoP2BupsgWn01m0zyFuxzJ+VxfFaKWFcOlaq3xu3rQAcALTl3wz5Q ElM+BtE8qGNQqw3+5KKfmptDCs/GlSy4dCSfyx4m4GQg2XlXjyuEgpIFBX4oDWgZbQOx 0sXcfSMDXSLA/EMYGgmtcOeNz/4w/CUtrXl/NVysD4aHFiDCbHcofnlACLrY7xD8G502 k/YaVNmofgMJ8xyj+FGYAsPNv5O4nYXAvmGusHis6j58dhM+YOdFZhWwnkHMXLK1eFyc d3ow== X-Gm-Message-State: AOAM530CcPNuo9P01q1u2TRW7bKcSVRcMY6rhH6nOdaOZWAB5uxsBvQM W6ewZo3FBYKnqoLffHgRvu7AhsMjAenAGDw9EPvBhTNI/Ao8KbIjAao47nQFO3FEhI7K8nABpS5 QZTeabxdFNCdDkNY= X-Received: by 2002:a05:6402:14da:: with SMTP id f26mr5128124edx.259.1627552444767; Thu, 29 Jul 2021 02:54:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQZrPy3ZPTfgLsh+Nd6hmR3oTXbT1ZlnE+NtZi1WIsSo84WJbKm/y9vC90yCqtwJH03+g9/A== X-Received: by 2002:a05:6402:14da:: with SMTP id f26mr5128108edx.259.1627552444570; Thu, 29 Jul 2021 02:54:04 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id a35sm987328edf.80.2021.07.29.02.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 02:54:04 -0700 (PDT) Date: Thu, 29 Jul 2021 11:54:02 +0200 From: Stefano Garzarella To: Fabian Ebner Subject: Re: [PATCH v2] block/io_uring: resubmit when result is -EAGAIN Message-ID: <20210729095402.efmtilww4mt2qghe@steredhat> References: <20210729091029.65369-1-f.ebner@proxmox.com> MIME-Version: 1.0 In-Reply-To: <20210729091029.65369-1-f.ebner@proxmox.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=sgarzare@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.719, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "open list:Linux io_uring" , Stefan Hajnoczi , Julia Suvorova , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , Aarushi Mehta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 29, 2021 at 11:10:29AM +0200, Fabian Ebner wrote: >Linux SCSI can throw spurious -EAGAIN in some corner cases in its >completion path, which will end up being the result in the completed >io_uring request. > >Resubmitting such requests should allow block jobs to complete, even >if such spurious errors are encountered. > >Co-authored-by: Stefan Hajnoczi >Reviewed-by: Stefano Garzarella >Signed-off-by: Fabian Ebner >--- > >Changes from v1: > * Focus on what's relevant for the patch itself in the commit > message. > * Add Stefan's comment. > * Add Stefano's R-b tag (I hope that's fine, since there was no > change code-wise). Yep, it's fine :-) Thanks, Stefano