From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Marek Vasut" <marex@denx.de>,
"Jeff Da Silva" <jdasilva@altera.com>,
"Chris Wulff" <crwulff@gmail.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Sandra Loosemore" <sandra@codesourcery.com>,
"Yves Vandervennet" <yvanderv@altera.com>,
"Ley Foon Tan" <lftan@altera.com>
Subject: [PATCH-for-6.1? v2] target/nios2: Mark raise_exception() as noreturn
Date: Thu, 29 Jul 2021 12:13:15 +0200 [thread overview]
Message-ID: <20210729101315.2318714-1-f4bug@amsat.org> (raw)
Raised exceptions don't return, so mark the helper with
noreturn.
Fixes: 032c76bc6f9 ("nios2: Add architecture emulation support")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2: use TCG_CALL_NO_WG instead of noreturn (rth)
Probably too late for 6.1, sorry I simply forgot to resend this patch
(and remember about it reviewing "Unaligned accesses for user-only"
https://www.mail-archive.com/qemu-devel@nongnu.org/msg826977.html)
---
target/nios2/helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/nios2/helper.h b/target/nios2/helper.h
index b0cb9146a5f..6c8f0b5b356 100644
--- a/target/nios2/helper.h
+++ b/target/nios2/helper.h
@@ -18,7 +18,7 @@
* <http://www.gnu.org/licenses/lgpl-2.1.html>
*/
-DEF_HELPER_2(raise_exception, void, env, i32)
+DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, i32)
#if !defined(CONFIG_USER_ONLY)
DEF_HELPER_2(mmu_read_debug, void, env, i32)
--
2.31.1
next reply other threads:[~2021-07-29 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 10:13 Philippe Mathieu-Daudé [this message]
2021-07-29 19:13 ` [PATCH-for-6.1? v2] target/nios2: Mark raise_exception() as noreturn Richard Henderson
2021-07-29 20:12 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729101315.2318714-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=crwulff@gmail.com \
--cc=jdasilva@altera.com \
--cc=lftan@altera.com \
--cc=marex@denx.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sandra@codesourcery.com \
--cc=yvanderv@altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).