From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7E4C4338F for ; Fri, 30 Jul 2021 09:52:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3924860C3F for ; Fri, 30 Jul 2021 09:52:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3924860C3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:55060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9PCM-0007yp-CU for qemu-devel@archiver.kernel.org; Fri, 30 Jul 2021 05:52:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9PBl-0007KN-Ic for qemu-devel@nongnu.org; Fri, 30 Jul 2021 05:52:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33985) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9PBj-0006KA-Uf for qemu-devel@nongnu.org; Fri, 30 Jul 2021 05:52:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627638738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iqUxQzrTDDq0yhi0pstCPjnr3Nh+HbBcjXkyIirRBr4=; b=LX6frGdvbw+QyfJxNlrm1lzPtQNGpRXFKooOlfqYlv0NqyI+4F4VzdsJMJVnqqoVTMPfQ6 WQFUDBDG+YjwoNxKZp+5bxoL9uIQ3cv1JXrnkKWQp/LmPyOOAgwNns4FKtqZYMOzWJow9e 7u7Q/hFiDFcjZVE3aqv8PkyUgKpjlH4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-hzEPYaL3NDGQvcw3d9MEsA-1; Fri, 30 Jul 2021 05:52:17 -0400 X-MC-Unique: hzEPYaL3NDGQvcw3d9MEsA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EAF30107B2A8; Fri, 30 Jul 2021 09:52:15 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2F04F5D6A1; Fri, 30 Jul 2021 09:52:12 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 8B2F718000BB; Fri, 30 Jul 2021 11:52:10 +0200 (CEST) Date: Fri, 30 Jul 2021 11:52:10 +0200 From: Gerd Hoffmann To: Antonio Caggiano Subject: Re: [PATCH v2 4/8] virtio-gpu: Shared memory capability Message-ID: <20210730095210.7popgdtcwml4wnzd@sirius.home.kraxel.org> References: <20210728134634.2142156-1-antonio.caggiano@collabora.com> <20210728134634.2142156-5-antonio.caggiano@collabora.com> MIME-Version: 1.0 In-Reply-To: <20210728134634.2142156-5-antonio.caggiano@collabora.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > - virtio_pci_add_shm_cap(vpci_dev, 4, 0, g->conf.hostmem, 0); > + virtio_pci_add_shm_cap(vpci_dev, 4, 0, g->conf.hostmem, VIRTIO_GPU_SHM_ID_HOST_VISIBLE); Squash that into patch #2 > --- a/include/standard-headers/linux/virtio_pci.h > +++ b/include/standard-headers/linux/virtio_pci.h > @@ -172,13 +172,6 @@ struct virtio_pci_cfg_cap { > uint8_t pci_cfg_data[4]; /* Data for BAR access. */ > }; > > -struct virtio_pci_shm_cap { > - struct virtio_pci_cap cap; > - uint32_t offset_hi; /* Most sig 32 bits of offset */ > - uint32_t length_hi; /* Most sig 32 bits of length */ > - uint8_t id; /* To distinguish shm chunks */ > -}; > - Hmm? I doubt this is correct ... take care, Gerd