From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [PATCH for-6.2 0/8] softmmu: Clean up arch_init.c
Date: Fri, 30 Jul 2021 11:59:39 +0100 [thread overview]
Message-ID: <20210730105947.28215-1-peter.maydell@linaro.org> (raw)
This patchset does some cleanups of arch_init.c. The bit I started
out caring about was getting rid of the TARGET_* ifdef ladder (in
patch 4 we make meson.build define QEMU_ARCH in config-target.h
instead) -- this kind of ifdef ladder is nasty because it's always
another place in the code that needs updating when we add or remove a
target. I think this was one of the last remaining "every single
arch touches this" ones. The rest of the patchset is stuff I noticed
when I started looking at what else arch_init.c was doing.
The graphic_width/height/depth target-specific defaults that
arch_init.c does also look like they could use cleanup. My guess is
that we should instead have a per-machine default graphics
width/height/depth. But that's a separate thing and more work than I
felt like doing this morning :-)
-- PMM
Peter Maydell (8):
softmmu: Use accel_find("xen") instead of xen_available()
monitor: Use accel_find("kvm") instead of kvm_available()
softmmu/arch_init.c: Trim down include list
meson.build: Define QEMU_ARCH in config-target.h
arch_init.h: Add QEMU_ARCH_HEXAGON
arch_init.h: Move QEMU_ARCH_VIRTIO_* to qdev-monitor.c
arch_init.h: Don't include arch_init.h unnecessarily
stubs: Remove unused arch_type.c stub
meson.build | 2 ++
include/sysemu/arch_init.h | 15 +--------
blockdev.c | 1 -
hw/i386/pc.c | 1 -
hw/i386/pc_piix.c | 1 -
hw/i386/pc_q35.c | 1 -
hw/mips/jazz.c | 1 -
hw/mips/malta.c | 1 -
hw/ppc/prep.c | 1 -
hw/riscv/sifive_e.c | 1 -
hw/riscv/sifive_u.c | 1 -
hw/riscv/spike.c | 1 -
hw/riscv/virt.c | 1 -
monitor/qmp-cmds.c | 3 +-
softmmu/arch_init.c | 66 --------------------------------------
softmmu/qdev-monitor.c | 9 ++++++
softmmu/vl.c | 6 ++--
stubs/arch_type.c | 4 ---
target/ppc/cpu_init.c | 1 -
target/s390x/cpu-sysemu.c | 1 -
stubs/meson.build | 1 -
21 files changed, 16 insertions(+), 103 deletions(-)
delete mode 100644 stubs/arch_type.c
--
2.20.1
next reply other threads:[~2021-07-30 11:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 10:59 Peter Maydell [this message]
2021-07-30 10:59 ` [PATCH for-6.2 1/8] softmmu: Use accel_find("xen") instead of xen_available() Peter Maydell
2021-07-30 18:41 ` Richard Henderson
2021-07-30 10:59 ` [PATCH for-6.2 2/8] monitor: Use accel_find("kvm") instead of kvm_available() Peter Maydell
2021-07-30 18:41 ` Richard Henderson
2021-07-30 10:59 ` [PATCH for-6.2 3/8] softmmu/arch_init.c: Trim down include list Peter Maydell
2021-07-30 18:42 ` Richard Henderson
2021-07-30 10:59 ` [PATCH for-6.2 4/8] meson.build: Define QEMU_ARCH in config-target.h Peter Maydell
2021-07-30 13:19 ` Philippe Mathieu-Daudé
2021-07-30 18:43 ` Richard Henderson
2021-07-30 10:59 ` [PATCH for-6.2 5/8] arch_init.h: Add QEMU_ARCH_HEXAGON Peter Maydell
2021-07-30 13:20 ` Philippe Mathieu-Daudé
2021-07-30 18:44 ` Richard Henderson
2021-07-30 19:36 ` Taylor Simpson
2021-07-30 10:59 ` [PATCH for-6.2 6/8] arch_init.h: Move QEMU_ARCH_VIRTIO_* to qdev-monitor.c Peter Maydell
2021-07-30 18:46 ` Richard Henderson
2021-08-26 14:41 ` Markus Armbruster
2021-07-30 10:59 ` [PATCH for-6.2 7/8] arch_init.h: Don't include arch_init.h unnecessarily Peter Maydell
2021-07-30 13:21 ` Philippe Mathieu-Daudé
2021-07-30 18:45 ` Richard Henderson
2021-08-01 0:54 ` Alistair Francis
2021-07-30 10:59 ` [PATCH for-6.2 8/8] stubs: Remove unused arch_type.c stub Peter Maydell
2021-07-30 13:23 ` Philippe Mathieu-Daudé
2021-07-30 18:46 ` Richard Henderson
2021-08-26 14:33 ` [PATCH for-6.2 0/8] softmmu: Clean up arch_init.c Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730105947.28215-1-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).