From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF2C7C4338F for ; Sat, 21 Aug 2021 19:06:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C5BA61057 for ; Sat, 21 Aug 2021 19:06:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C5BA61057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:53614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHWJz-0004kE-U5 for qemu-devel@archiver.kernel.org; Sat, 21 Aug 2021 15:06:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHWIi-0003Kq-87 for qemu-devel@nongnu.org; Sat, 21 Aug 2021 15:05:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHWIf-0001TM-12 for qemu-devel@nongnu.org; Sat, 21 Aug 2021 15:05:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629572699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lh3prZx6bYeEJxzx+e8m4FlRwm7PtVav/OgR6iCsN3Y=; b=XV8fhSmwm3KE2LTCgDKknHzeTzAp02Qg13AGUn71KcH355JDmy18V1KpWVPXBSMG5E3o1K ciM5ZPxtyEHoLQbY0sCnqL8C4Wp+C8I2gDH6cELjad2cLJsv9wDMMBfgazOH3r5Vyq6trz ypmeCh+PAwGun4YLj01pxcwUyqHMV4U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-NnAUv3dTMI6AzZRIsufCqQ-1; Sat, 21 Aug 2021 15:04:57 -0400 X-MC-Unique: NnAUv3dTMI6AzZRIsufCqQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC00F8042F4; Sat, 21 Aug 2021 19:04:56 +0000 (UTC) Received: from scv.redhat.com (unknown [10.22.19.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id B6E6717010; Sat, 21 Aug 2021 19:04:55 +0000 (UTC) From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH 1/1] python: Update for pylint 2.10 Date: Sat, 21 Aug 2021 15:04:51 -0400 Message-Id: <20210821190451.3039867-2-jsnow@redhat.com> In-Reply-To: <20210821190451.3039867-1-jsnow@redhat.com> References: <20210821190451.3039867-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , G S Niteesh Babu , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" A few new annoyances. Of note is the new warning for an unspecified encoding when opening a text file, which actually does indicate a potentially real problem; see https://www.python.org/dev/peps/pep-0597/#motivation I was under the impression that open would try to figure out the encoding of a file for you -- apparently this is completely false. It uses the platform's preferred encoding, whatever that may be. What we ought to use here, I believe, is sys.stderr.encoding. Signed-off-by: John Snow --- python/qemu/machine/machine.py | 6 ++++-- python/setup.cfg | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py index 971ed7e8c6..1f47fc5a2b 100644 --- a/python/qemu/machine/machine.py +++ b/python/qemu/machine/machine.py @@ -25,6 +25,7 @@ import signal import socket import subprocess +import sys import tempfile from types import TracebackType from typing import ( @@ -284,7 +285,8 @@ def get_pid(self) -> Optional[int]: def _load_io_log(self) -> None: if self._qemu_log_path is not None: - with open(self._qemu_log_path, "r") as iolog: + with open(self._qemu_log_path, "r", + encoding=sys.stdout.encoding) as iolog: self._iolog = iolog.read() @property @@ -565,7 +567,7 @@ def _qmp(self) -> QEMUMonitorProtocol: @classmethod def _qmp_args(cls, _conv_keys: bool = True, **args: Any) -> Dict[str, Any]: - qmp_args = dict() + qmp_args = {} for key, value in args.items(): if _conv_keys: qmp_args[key.replace('_', '-')] = value diff --git a/python/setup.cfg b/python/setup.cfg index 14bab90288..f220419755 100644 --- a/python/setup.cfg +++ b/python/setup.cfg @@ -104,6 +104,7 @@ good-names=i, [pylint.similarities] # Ignore imports when computing similarities. ignore-imports=yes +ignore-signatures=yes [isort] force_grid_wrap=4 -- 2.31.1