From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Andrew Jones" <drjones@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
peterx@redhat.com,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH 0/2] dump-guest-memory: Add blocker for migration
Date: Tue, 24 Aug 2021 11:27:19 -0400 [thread overview]
Message-ID: <20210824152721.79747-1-peterx@redhat.com> (raw)
Both dump-guest-memory and live migration have vm state cached internally.
Allowing them to happen together means the vm state can be messed up. Simply
block live migration for dump-guest-memory.
One trivial thing to mention is we should still allow dump-guest-memory even if
-only-migratable is specified, because that flag should majorly be used to
guarantee not adding devices that will block migration by accident. Dump guest
memory is not like that - it'll only block for the seconds when it's dumping.
Thanks,
Peter Xu (2):
migration: Add migrate_add_blocker_internal()
dump-guest-memory: Block live migration
dump/dump.c | 20 +++++++++++++++-----
include/migration/blocker.h | 16 ++++++++++++++++
include/sysemu/dump.h | 1 +
migration/migration.c | 21 +++++++++++++--------
4 files changed, 45 insertions(+), 13 deletions(-)
--
2.31.1
next reply other threads:[~2021-08-24 15:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 15:27 Peter Xu [this message]
2021-08-24 15:27 ` [PATCH 1/2] migration: Add migrate_add_blocker_internal() Peter Xu
2021-08-24 18:04 ` Marc-André Lureau
2021-08-25 8:04 ` Juan Quintela
2021-08-24 15:27 ` [PATCH 2/2] dump-guest-memory: Block live migration Peter Xu
2021-08-24 18:04 ` Marc-André Lureau
2021-08-24 19:39 ` Peter Xu
2021-08-25 7:36 ` Marc-André Lureau
2021-08-25 20:48 ` Peter Xu
2021-08-25 7:54 ` [PATCH 0/2] dump-guest-memory: Add blocker for migration Markus Armbruster
2021-08-25 21:32 ` Peter Xu
2021-09-01 11:35 ` Markus Armbruster
2021-09-03 16:08 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824152721.79747-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).