From: Eric Blake <eblake@redhat.com>
To: Stefan Reiter <s.reiter@proxmox.com>
Cc: "Wolfgang Bumiller" <w.bumiller@proxmox.com>,
QEMU <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Subject: Re: [PATCH 2/2] monitor: allow VNC related QMP and HMP commands to take a display ID
Date: Wed, 25 Aug 2021 14:20:06 -0500 [thread overview]
Message-ID: <20210825192006.jklsbrdc43cojctq@redhat.com> (raw)
In-Reply-To: <4400f41b-4ecc-9340-a20d-8acdaae033be@proxmox.com>
On Wed, Aug 25, 2021 at 01:26:09PM +0200, Stefan Reiter wrote:
> > It's not something done with other commands afaik, feels a bit awkward (the
> > "connected = display"...).
> >
>
> Indeed, if there is a better way I'd love to use it.
>
> One idea I had was making the parameter 'connected' OR 'display', since
> the former only supports 'keep' for VNC anyway - but that introduces a
> weird double-meaning again.
That's not too bad. See for example hmp_hostfwd_add, which merely
names its two arguments arg1 and arg2. Naming your argument 'arg'
instead of 'connected' or 'display' lets you interpret it in whatever
context-sensitive manner is easiest for your use case.
> > Is it really necessary to add support for HMP?
> >
>
> For us it would be, as we provide an easy HMP interface to our users, but
> not a QMP one, so it ended up being a bit of a regression with 6.0.
Okay, you do have a point that until users can reliably use QMP to do
the same, then keeping pre-existing HMP commands working is
worthwhile. But long-term HMP stability is not an end goal.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-08-25 19:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 9:36 [PATCH 0/2] VNC-related HMP/QMP fixes Stefan Reiter
2021-08-25 9:37 ` [PATCH 1/2] monitor/hmp: correctly invert password argument detection again Stefan Reiter
2021-08-25 10:42 ` Marc-André Lureau
2021-08-25 9:37 ` [PATCH 2/2] monitor: allow VNC related QMP and HMP commands to take a display ID Stefan Reiter
2021-08-25 10:59 ` Marc-André Lureau
2021-08-25 11:26 ` Stefan Reiter
2021-08-25 19:20 ` Eric Blake [this message]
2021-08-25 19:16 ` Eric Blake
2021-08-31 12:20 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825192006.jklsbrdc43cojctq@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=s.reiter@proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).