qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Subject: [PATCH 0/2] elf2dmp: Fix minor Coverity nits
Date: Wed,  1 Sep 2021 15:39:08 +0100	[thread overview]
Message-ID: <20210901143910.17112-1-peter.maydell@linaro.org> (raw)

Coverity complains about a couple of minor issues in elf2dmp:
 * we weren't checking the return value from curl_easy_setopt()
 * we might divide by zero if presented with a corrupt PDB file

This patchseries fixes those.

NB: I have only compile tested this as I don't have any
files to test it with.

thanks
-- PMM

Peter Maydell (2):
  elf2dmp: Check curl_easy_setopt() return value
  elf2dmp: Fail cleanly if PDB file specifies zero block_size

 contrib/elf2dmp/download.c | 28 +++++++++++++++++-----------
 contrib/elf2dmp/pdb.c      |  4 ++++
 2 files changed, 21 insertions(+), 11 deletions(-)

-- 
2.20.1



             reply	other threads:[~2021-09-01 14:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 14:39 Peter Maydell [this message]
2021-09-01 14:39 ` [PATCH 1/2] elf2dmp: Check curl_easy_setopt() return value Peter Maydell
2021-09-01 15:25   ` Philippe Mathieu-Daudé
2021-09-08 21:43     ` Viktor Prutyanov
2021-09-08 23:25       ` Philippe Mathieu-Daudé
2021-09-01 14:39 ` [PATCH 2/2] elf2dmp: Fail cleanly if PDB file specifies zero block_size Peter Maydell
2021-09-08 21:28   ` Viktor Prutyanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210901143910.17112-1-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=viktor.prutyanov@phystech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).