qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	qemu-block@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"David Hildenbrand" <david@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-arm@nongnu.org, "John Snow" <jsnow@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	"Hanna Reitz" <hreitz@redhat.com>,
	qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PATCH v3 08/28] hw/acpi: Avoid truncating acpi_data_len() to 32-bit
Date: Fri,  3 Sep 2021 19:44:50 +0200	[thread overview]
Message-ID: <20210903174510.751630-9-philmd@redhat.com> (raw)
In-Reply-To: <20210903174510.751630-1-philmd@redhat.com>

acpi_data_len() returns an unsigned type, which might be bigger
than 32-bit (although it is unlikely such value is returned).
Hold the returned value in an 'unsigned' type to avoid unlikely
size truncation.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/arm/virt-acpi-build.c | 2 +-
 hw/i386/acpi-build.c     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 037cc1fd82c..95543d43e2a 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -885,7 +885,7 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)
 
 static void acpi_ram_update(MemoryRegion *mr, GArray *data)
 {
-    uint32_t size = acpi_data_len(data);
+    unsigned size = acpi_data_len(data);
 
     /* Make sure RAM size is correct - in case it got changed
      * e.g. by migration */
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index a33ac8b91e1..aa269914b49 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -2660,7 +2660,7 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine)
 
 static void acpi_ram_update(MemoryRegion *mr, GArray *data)
 {
-    uint32_t size = acpi_data_len(data);
+    unsigned size = acpi_data_len(data);
 
     /* Make sure RAM size is correct - in case it got changed e.g. by migration */
     memory_region_ram_resize(mr, size, &error_abort);
@@ -2783,7 +2783,7 @@ void acpi_setup(void)
          * Though RSDP is small, its contents isn't immutable, so
          * we'll update it along with the rest of tables on guest access.
          */
-        uint32_t rsdp_size = acpi_data_len(tables.rsdp);
+        unsigned rsdp_size = acpi_data_len(tables.rsdp);
 
         build_state->rsdp = g_memdup(tables.rsdp->data, rsdp_size);
         fw_cfg_add_file_callback(x86ms->fw_cfg, ACPI_BUILD_RSDP_FILE,
-- 
2.31.1



  parent reply	other threads:[~2021-09-03 17:54 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 17:44 [PATCH v3 00/28] glib: Replace g_memdup() by g_memdup2() Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 01/28] hw/hyperv/vmbus: Remove unused vmbus_load/save_req() Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 02/28] glib-compat: Introduce g_memdup2() wrapper Philippe Mathieu-Daudé
2021-09-03 20:37   ` Eric Blake
2021-12-16 14:11   ` Alex Bennée
2021-12-16 18:39     ` Philippe Mathieu-Daudé
2021-12-17 11:10       ` Alex Bennée
2021-12-17 11:41         ` Laurent Vivier
2021-12-17 12:15           ` Alex Bennée
2021-12-17 13:39         ` Daniel P. Berrangé
2021-12-17 13:43     ` Daniel P. Berrangé
2021-12-17 14:53       ` Alex Bennée
2021-12-17 15:01         ` Daniel P. Berrangé
2021-12-17 10:55   ` Laurent Vivier
2021-09-03 17:44 ` [PATCH v3 03/28] qapi: Replace g_memdup() by g_memdup2() Philippe Mathieu-Daudé
2021-09-03 21:10   ` Eric Blake
2021-09-03 17:44 ` [PATCH v3 04/28] accel/tcg: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 05/28] block/qcow2-bitmap: " Philippe Mathieu-Daudé
2021-09-03 21:13   ` Eric Blake
2021-09-03 21:14     ` Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 06/28] softmmu: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 07/28] hw/9pfs: " Philippe Mathieu-Daudé
2021-09-04 12:25   ` Christian Schoenebeck
2021-09-03 17:44 ` Philippe Mathieu-Daudé [this message]
2021-09-03 17:44 ` [PATCH v3 09/28] hw/acpi: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 10/28] hw/core/machine: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 11/28] hw/hppa/machine: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 12/28] hw/i386/multiboot: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 13/28] hw/net/eepro100: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 14/28] hw/nvram/fw_cfg: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 15/28] hw/scsi/mptsas: " Philippe Mathieu-Daudé
2021-09-03 17:44 ` [PATCH v3 16/28] hw/ppc/spapr_pci: " Philippe Mathieu-Daudé
2021-09-04  3:38   ` David Gibson
2021-09-03 17:44 ` [PATCH v3 17/28] hw/rdma: " Philippe Mathieu-Daudé
2021-09-03 17:45 ` [PATCH v3 18/28] hw/vfio/pci: " Philippe Mathieu-Daudé
2021-09-03 17:45 ` [RFC PATCH v3 19/28] hw/virtio: " Philippe Mathieu-Daudé
2022-04-01 10:50   ` Eugenio Perez Martin
2021-09-03 17:45 ` [PATCH v3 20/28] net/colo: " Philippe Mathieu-Daudé
2021-09-03 17:45 ` [RFC PATCH v3 21/28] ui/clipboard: " Philippe Mathieu-Daudé
2021-09-03 17:45 ` [RFC PATCH v3 22/28] linux-user: " Philippe Mathieu-Daudé
2021-09-03 17:45 ` [PATCH v3 23/28] tests/unit: " Philippe Mathieu-Daudé
2021-09-03 17:45 ` [PATCH v3 24/28] tests/qtest: " Philippe Mathieu-Daudé
2021-09-04  5:48   ` Thomas Huth
2021-12-17 10:56   ` Laurent Vivier
2021-09-03 17:45 ` [PATCH v3 25/28] target/arm: " Philippe Mathieu-Daudé
2021-09-03 17:45 ` [PATCH v3 26/28] target/ppc: " Philippe Mathieu-Daudé
2021-09-04  3:38   ` David Gibson
2021-09-03 17:45 ` [PATCH v3 27/28] contrib: " Philippe Mathieu-Daudé
2021-09-03 17:45 ` [PATCH v3 28/28] checkpatch: Do not allow deprecated g_memdup() Philippe Mathieu-Daudé
2021-09-03 21:17   ` Eric Blake
2021-12-17 10:58   ` Laurent Vivier
2021-12-15 16:54 ` [PATCH v3 00/28] glib: Replace g_memdup() by g_memdup2() Philippe Mathieu-Daudé
2021-12-17 10:59   ` Laurent Vivier
2024-05-08 21:22 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903174510.751630-9-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).