From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1952C433F5 for ; Thu, 9 Sep 2021 02:35:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71A836113A for ; Thu, 9 Sep 2021 02:35:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71A836113A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mO9uJ-0002iG-IS for qemu-devel@archiver.kernel.org; Wed, 08 Sep 2021 22:35:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mO9tf-00021Z-8b for qemu-devel@nongnu.org; Wed, 08 Sep 2021 22:34:39 -0400 Received: from mga03.intel.com ([134.134.136.65]:39953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mO9tb-0005rD-FA for qemu-devel@nongnu.org; Wed, 08 Sep 2021 22:34:39 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="220707938" X-IronPort-AV: E=Sophos;i="5.85,279,1624345200"; d="scan'208";a="220707938" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Sep 2021 19:34:32 -0700 X-IronPort-AV: E=Sophos;i="5.85,279,1624345200"; d="scan'208";a="539200526" Received: from yangzhon-virtual.bj.intel.com (HELO yangzhon-Virtual) ([10.238.144.101]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA256; 08 Sep 2021 19:34:29 -0700 Date: Thu, 9 Sep 2021 10:20:36 +0800 From: Yang Zhong To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH 3/7] i386: Add sgx_get_info() interface Message-ID: <20210909022036.GB21362@yangzhon-Virtual> References: <20210908081937.77254-1-yang.zhong@intel.com> <20210908081937.77254-4-yang.zhong@intel.com> <8802ca02-9ebf-d599-f6b4-87ae5640dad4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8802ca02-9ebf-d599-f6b4-87ae5640dad4@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Received-SPF: pass client-ip=134.134.136.65; envelope-from=yang.zhong@intel.com; helo=mga03.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, pbonzini@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, seanjc@google.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 08, 2021 at 10:32:27AM +0200, Philippe Mathieu-Daudé wrote: > On 9/8/21 10:19 AM, Yang Zhong wrote: > > Add the sgx_get_info() interface for hmp and QMP usage, which > > will get the SGX info from this API. > > > > Signed-off-by: Yang Zhong > > --- > > hw/i386/sgx.c | 21 +++++++++++++++++++++ > > include/hw/i386/sgx.h | 11 +++++++++++ > > target/i386/monitor.c | 32 ++++++++++++++++++++++++++++---- > > 3 files changed, 60 insertions(+), 4 deletions(-) > > create mode 100644 include/hw/i386/sgx.h > > > @@ -766,12 +767,35 @@ qmp_query_sev_attestation_report(const char *mnonce, Error **errp) > > > > SGXInfo *qmp_query_sgx(Error **errp) > > { > > - error_setg(errp, QERR_FEATURE_DISABLED, "query-sgx"); > > > void hmp_info_sgx(Monitor *mon, const QDict *qdict) > > { > > - error_setg(errp, QERR_FEATURE_DISABLED, "query-sgx"); > > - return NULL; > > What is the point of patches #1 & #2? Why not squash all here? Philippe, The different user usage, Monitor and QMP tool to get the some info from VM. I am okay to squash those 3 patches into ones, thanks! Yang