From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pkrempa@redhat.com, berrange@redhat.com,
ehabkost@redhat.com, qemu-block@nongnu.org,
libvir-list@redhat.com, armbru@redhat.com, its@irrelevant.dk,
pbonzini@redhat.com
Subject: [PATCH 02/11] iotests/245: Fix type for iothread property
Date: Fri, 24 Sep 2021 11:04:18 +0200 [thread overview]
Message-ID: <20210924090427.9218-3-kwolf@redhat.com> (raw)
In-Reply-To: <20210924090427.9218-1-kwolf@redhat.com>
iothread is a string property, so None (= JSON null) is not a valid
value for it. Pass the empty string instead to get the default iothread.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/245 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
index bf8261eec0..9b12b42eed 100755
--- a/tests/qemu-iotests/245
+++ b/tests/qemu-iotests/245
@@ -1189,10 +1189,10 @@ class TestBlockdevReopen(iotests.QMPTestCase):
self.run_test_iothreads('iothread0', 'iothread0')
def test_iothreads_switch_backing(self):
- self.run_test_iothreads('iothread0', None)
+ self.run_test_iothreads('iothread0', '')
def test_iothreads_switch_overlay(self):
- self.run_test_iothreads(None, 'iothread0')
+ self.run_test_iothreads('', 'iothread0')
if __name__ == '__main__':
iotests.activate_logging()
--
2.31.1
next prev parent reply other threads:[~2021-09-24 9:11 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:04 [PATCH 00/11] qdev: Add JSON -device and fix QMP device_add Kevin Wolf
2021-09-24 9:04 ` [PATCH 01/11] qom: Reduce use of error_propagate() Kevin Wolf
2021-09-24 13:23 ` Vladimir Sementsov-Ogievskiy
2021-09-24 14:04 ` Markus Armbruster
2021-09-24 18:14 ` Eric Blake
2021-09-24 9:04 ` Kevin Wolf [this message]
2021-09-24 13:33 ` [PATCH 02/11] iotests/245: Fix type for iothread property Vladimir Sementsov-Ogievskiy
2021-09-24 9:04 ` [PATCH 03/11] iotests/051: Fix typo Kevin Wolf
2021-09-24 13:35 ` Vladimir Sementsov-Ogievskiy
2021-09-24 9:04 ` [PATCH 04/11] qdev: Avoid using string visitor for properties Kevin Wolf
2021-09-24 18:40 ` Eric Blake
2021-09-24 9:04 ` [PATCH 05/11] qdev: Make DeviceState.id independent of QemuOpts Kevin Wolf
2021-09-24 14:02 ` Vladimir Sementsov-Ogievskiy
2021-09-24 15:10 ` Kevin Wolf
2021-09-24 15:14 ` Vladimir Sementsov-Ogievskiy
2021-09-24 9:04 ` [PATCH 06/11] qdev: Add Error parameter to qdev_set_id() Kevin Wolf
2021-09-24 14:09 ` Vladimir Sementsov-Ogievskiy
2021-09-27 10:33 ` Damien Hedde
2021-10-05 11:09 ` Kevin Wolf
2021-09-24 9:04 ` [PATCH 07/11] qemu-option: Allow deleting opts during qemu_opts_foreach() Kevin Wolf
2021-09-24 14:14 ` Vladimir Sementsov-Ogievskiy
2021-09-24 9:04 ` [PATCH 08/11] qdev: Base object creation on QDict rather than QemuOpts Kevin Wolf
2021-09-24 18:53 ` Eric Blake
2021-09-24 9:04 ` [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add Kevin Wolf
2021-09-24 18:56 ` Eric Blake
2021-09-27 11:06 ` Damien Hedde
2021-09-27 11:39 ` Kevin Wolf
2021-10-05 14:37 ` Kevin Wolf
2021-10-05 15:52 ` Damien Hedde
2021-10-05 17:33 ` Kevin Wolf
2021-10-06 8:21 ` Juan Quintela
2021-10-06 9:20 ` Laurent Vivier
2021-10-06 10:53 ` Kevin Wolf
2021-10-06 11:09 ` Laurent Vivier
2021-10-01 14:42 ` Peter Krempa
2021-10-04 12:18 ` Damien Hedde
2021-10-04 14:22 ` Kevin Wolf
2021-09-24 9:04 ` [PATCH 10/11] vl: Enable JSON syntax for -device Kevin Wolf
2021-09-24 19:00 ` Eric Blake
2021-09-24 9:04 ` [PATCH 11/11] Deprecate stable non-JSON -device and -object Kevin Wolf
2021-09-24 19:02 ` Eric Blake
2021-09-27 8:15 ` Paolo Bonzini
2021-09-27 8:21 ` Daniel P. Berrangé
2021-09-27 10:17 ` Kevin Wolf
2021-09-27 10:37 ` Daniel P. Berrangé
2021-09-27 9:00 ` Peter Maydell
2021-09-27 11:27 ` Kevin Wolf
2021-09-27 12:52 ` Peter Maydell
2021-09-27 16:10 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924090427.9218-3-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=its@irrelevant.dk \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).