qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Eric Blake <eblake@redhat.com>
Subject: [PULL 11/25] tests/qapi-schema: Prepare for simple union UserDefListUnion removal
Date: Sat, 25 Sep 2021 08:25:11 +0200	[thread overview]
Message-ID: <20210925062525.988405-12-armbru@redhat.com> (raw)
In-Reply-To: <20210925062525.988405-1-armbru@redhat.com>

Simple unions predate flat unions.  Having both complicates the QAPI
schema language and the QAPI generator.  We haven't been using simple
unions in new code for a long time, because they are less flexible and
somewhat awkward on the wire.

To prepare for their removal, simple union UserDefListUnion has to go.
It is used to cover arrays.  The next few commits will eliminate its
uses, and then it gets deleted.  As a first step, provide struct
ArrayStruct for the tests to be rewritten.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20210917143134.412106-12-armbru@redhat.com>
---
 tests/qapi-schema/qapi-schema-test.json | 16 ++++++++++++++++
 tests/qapi-schema/qapi-schema-test.out  | 16 ++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/tests/qapi-schema/qapi-schema-test.json b/tests/qapi-schema/qapi-schema-test.json
index 3c43e14e22..b2d795cb19 100644
--- a/tests/qapi-schema/qapi-schema-test.json
+++ b/tests/qapi-schema/qapi-schema-test.json
@@ -140,6 +140,22 @@
             'sizes': ['size'],
             'any': ['any'],
             'user': ['Status'] } } # intentional forward ref. to sub-module
+{ 'struct': 'ArrayStruct',
+  'data': { 'integer': ['int'],
+            's8': ['int8'],
+            's16': ['int16'],
+            's32': ['int32'],
+            's64': ['int64'],
+            'u8': ['uint8'],
+            'u16': ['uint16'],
+            'u32': ['uint32'],
+            'u64': ['uint64'],
+            'number': ['number'],
+            'boolean': ['bool'],
+            'string': ['str'],
+            '*sz': ['size'],
+            '*any': ['any'],
+            '*user': ['Status'] } } # intentional forward ref. to sub-module
 
 # for testing sub-modules
 { 'include': 'include/sub-module.json' }
diff --git a/tests/qapi-schema/qapi-schema-test.out b/tests/qapi-schema/qapi-schema-test.out
index d557fe2d89..7a488c1d06 100644
--- a/tests/qapi-schema/qapi-schema-test.out
+++ b/tests/qapi-schema/qapi-schema-test.out
@@ -189,6 +189,22 @@ object UserDefListUnion
     case sizes: q_obj_sizeList-wrapper
     case any: q_obj_anyList-wrapper
     case user: q_obj_StatusList-wrapper
+object ArrayStruct
+    member integer: intList optional=False
+    member s8: int8List optional=False
+    member s16: int16List optional=False
+    member s32: int32List optional=False
+    member s64: int64List optional=False
+    member u8: uint8List optional=False
+    member u16: uint16List optional=False
+    member u32: uint32List optional=False
+    member u64: uint64List optional=False
+    member number: numberList optional=False
+    member boolean: boolList optional=False
+    member string: strList optional=False
+    member sz: sizeList optional=True
+    member any: anyList optional=True
+    member user: StatusList optional=True
 include include/sub-module.json
 command user-def-cmd None -> None
     gen=True success_response=True boxed=False oob=False preconfig=False
-- 
2.31.1



  parent reply	other threads:[~2021-09-25  6:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  6:25 [PULL 00/25] QAPI patches patches for 2021-09-25 Markus Armbruster
2021-09-25  6:25 ` [PULL 01/25] qapi: Tidy up unusual line breaks Markus Armbruster
2021-09-25  6:25 ` [PULL 02/25] qapi: Stop enforcing "type name should not end in 'Kind' Markus Armbruster
2021-09-25  6:25 ` [PULL 03/25] qapi: Convert simple union KeyValue to flat one Markus Armbruster
2021-09-25  6:25 ` [PULL 04/25] qapi: Convert simple union InputEvent " Markus Armbruster
2021-09-25  6:25 ` [PULL 05/25] qapi: Convert simple union TpmTypeOptions " Markus Armbruster
2021-09-25  6:25 ` [PULL 06/25] qapi: Convert simple union MemoryDeviceInfo " Markus Armbruster
2021-09-25  6:25 ` [PULL 07/25] qapi: Convert simple union ChardevBackend " Markus Armbruster
2021-09-25  6:25 ` [PULL 08/25] qapi: Convert simple union SocketAddressLegacy " Markus Armbruster
2021-09-25  6:25 ` [PULL 09/25] qapi: Convert simple union ImageInfoSpecific " Markus Armbruster
2021-09-25  6:25 ` [PULL 10/25] qapi: Convert simple union TransactionAction " Markus Armbruster
2021-09-25  6:25 ` Markus Armbruster [this message]
2021-09-25  6:25 ` [PULL 12/25] test-qobject-input-visitor: Wean off UserDefListUnion Markus Armbruster
2021-09-25  6:25 ` [PULL 13/25] test-qobject-output-visitor: " Markus Armbruster
2021-09-25  6:25 ` [PULL 14/25] test-clone-visitor: " Markus Armbruster
2021-09-25  6:25 ` [PULL 15/25] tests/qapi-schema: " Markus Armbruster
2021-09-25  6:25 ` [PULL 16/25] tests/qapi-schema: Simple union UserDefListUnion is now unused, drop Markus Armbruster
2021-09-25  6:25 ` [PULL 17/25] tests/qapi-schema: Rewrite simple union TestIfUnion to be flat Markus Armbruster
2021-09-25  6:25 ` [PULL 18/25] test-clone-visitor: Wean off __org.qemu_x-Union1 Markus Armbruster
2021-09-25  6:25 ` [PULL 19/25] tests/qapi-schema: Drop simple union __org.qemu_x-Union1 Markus Armbruster
2021-09-25  6:25 ` [PULL 20/25] tests/qapi-schema: Purge simple unions from tests Markus Armbruster
2021-09-25  6:25 ` [PULL 21/25] qapi: Drop simple unions Markus Armbruster
2021-09-25  6:25 ` [PULL 22/25] tests/qapi-schema: Rename flat-union-* test cases to union-* Markus Armbruster
2021-09-25  6:25 ` [PULL 23/25] test-clone-visitor: Correct an accidental rename Markus Armbruster
2021-09-25  6:25 ` [PULL 24/25] tests/qapi-schema: Use Python OSError instead of outmoded IOError Markus Armbruster
2021-09-25  6:25 ` [PULL 25/25] tests/qapi-schema: Make test-qapi.py -u work when files are absent Markus Armbruster
2021-09-25  8:44 ` [PULL 00/25] QAPI patches patches for 2021-09-25 Peter Maydell
2021-09-27 12:41   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210925062525.988405-12-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).