From: Gerd Hoffmann <kraxel@redhat.com>
To: "Jose R. Ziviani" <jziviani@suse.de>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/2] modules: Improve modinfo.c support
Date: Wed, 29 Sep 2021 07:09:08 +0200 [thread overview]
Message-ID: <20210929050908.3fqf3wwbk6vrtziu@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210928204628.20001-1-jziviani@suse.de>
On Tue, Sep 28, 2021 at 05:46:26PM -0300, Jose R. Ziviani wrote:
> This patchset introduces the modinfo_kconfig aiming for a fine-tune
> control of module loading by simply checking Kconfig options during the
> compile time, then generates one modinfo-<target>-softmmu.c per target.
>
> The main reason of this change is to fix problems like:
> $ ./qemu-system-s390x -nodefaults -display none -accel tcg -M none -device help | head
> Failed to open module: /.../hw-display-qxl.so: undefined symbol: vga_ioport_read
> Failed to open module: /.../hw-display-virtio-vga.so: undefined symbol: vmstate_vga_common
> Failed to open module: /.../hw-display-virtio-vga.so: undefined symbol: vmstate_vga_common
> Failed to open module: /.../hw-display-virtio-vga-gl.so: undefined symbol: have_vga
> Failed to open module: /.../hw-usb-smartcard.so: undefined symbol: ccid_card_ccid_attach
> Failed to open module: /.../hw-usb-redirect.so: undefined symbol: vmstate_usb_device
> Failed to open module: /.../hw-usb-host.so: undefined symbol: vmstate_usb_device
>
> With this patch, I run this small script successfuly:
> #!/bin/bash
> pushd ~/suse/virtualization/qemu/build
> for qemu in qemu-system-*
> do
> [[ -f "$qemu" ]] || continue
> res=$(./$qemu -nodefaults -display none -accel tcg -M none -device help 2>&1 | grep "Failed to" > /dev/null; echo $?)
> [[ $res -eq 0 ]] && echo "Error: $qemu"
> done
> popd
>
> Also run 'make check' and 'check-acceptance' without any failures.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2021-09-29 5:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 20:46 [PATCH v3 0/2] modules: Improve modinfo.c support Jose R. Ziviani
2021-09-28 20:46 ` [PATCH v3 1/2] modules: introduces module_kconfig directive Jose R. Ziviani
2021-09-28 20:46 ` [PATCH v3 2/2] modules: generates per-target modinfo Jose R. Ziviani
2021-09-29 5:09 ` Gerd Hoffmann [this message]
2022-05-24 11:49 ` [PATCH v3 0/2] modules: Improve modinfo.c support Dario Faggioli
2022-05-25 6:32 ` Gerd Hoffmann
2022-05-25 9:00 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929050908.3fqf3wwbk6vrtziu@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=jziviani@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).