qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PULL 05/13] macfb: use memory_region_init_ram() in macfb_common_realize() for the framebuffer
Date: Fri,  8 Oct 2021 13:45:10 +0200	[thread overview]
Message-ID: <20211008114518.757615-6-laurent@vivier.eu> (raw)
In-Reply-To: <20211008114518.757615-1-laurent@vivier.eu>

From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Currently macfb_common_realize() defines the framebuffer RAM memory region as
being non-migrateable but then immediately registers it for migration. Replace
memory_region_init_ram_nomigrate() with memory_region_init_ram() which is clearer
and does exactly the same thing.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20211007221253.29024-6-mark.cave-ayland@ilande.co.uk>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/display/macfb.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index 39dab49026c3..f88f5a652394 100644
--- a/hw/display/macfb.c
+++ b/hw/display/macfb.c
@@ -367,11 +367,10 @@ static bool macfb_common_realize(DeviceState *dev, MacfbState *s, Error **errp)
     memory_region_init_io(&s->mem_ctrl, OBJECT(dev), &macfb_ctrl_ops, s,
                           "macfb-ctrl", 0x1000);
 
-    memory_region_init_ram_nomigrate(&s->mem_vram, OBJECT(dev), "macfb-vram",
-                                     MACFB_VRAM_SIZE, &error_abort);
+    memory_region_init_ram(&s->mem_vram, OBJECT(dev), "macfb-vram",
+                           MACFB_VRAM_SIZE, &error_abort);
     s->vram = memory_region_get_ram_ptr(&s->mem_vram);
     s->vram_bit_mask = MACFB_VRAM_SIZE - 1;
-    vmstate_register_ram(&s->mem_vram, dev);
     memory_region_set_coalescing(&s->mem_vram);
 
     return true;
-- 
2.31.1



  parent reply	other threads:[~2021-10-08 12:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08 11:45 [PULL 00/13] M68k next patches Laurent Vivier
2021-10-08 11:45 ` [PULL 01/13] macfb: handle errors that occur during realize Laurent Vivier
2021-10-08 11:45 ` [PULL 02/13] macfb: update macfb.c to use the Error API best practices Laurent Vivier
2021-10-08 11:45 ` [PULL 03/13] macfb: fix invalid object reference in macfb_common_realize() Laurent Vivier
2021-10-08 11:45 ` [PULL 04/13] macfb: fix overflow of color_palette array Laurent Vivier
2021-10-08 11:45 ` Laurent Vivier [this message]
2021-10-08 11:45 ` [PULL 06/13] macfb: add trace events for reading and writing the control registers Laurent Vivier
2021-10-08 11:45 ` [PULL 07/13] macfb: implement mode sense to allow display type to be detected Laurent Vivier
2021-10-08 11:45 ` [PULL 08/13] macfb: add qdev property to specify display type Laurent Vivier
2021-10-08 11:45 ` [PULL 09/13] macfb: add common monitor modes supported by the MacOS toolbox ROM Laurent Vivier
2021-11-05 15:56   ` Peter Maydell
2021-11-05 16:43     ` Laurent Vivier
2021-10-08 11:45 ` [PULL 10/13] macfb: fix up 1-bit pixel encoding Laurent Vivier
2021-10-08 11:45 ` [PULL 11/13] macfb: fix 24-bit RGB " Laurent Vivier
2021-10-08 11:45 ` [PULL 12/13] macfb: add vertical blank interrupt Laurent Vivier
2021-10-08 11:45 ` [PULL 13/13] q800: wire macfb IRQ to separate video interrupt on VIA2 Laurent Vivier
2021-10-08 13:29 ` [PULL 00/13] M68k next patches Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211008114518.757615-6-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=f4bug@amsat.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).