From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: pbonzini@redhat.com, peter.maydell@linaro.org
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
richard.henderson@linaro.org, armbru@redhat.com,
qemu-stable@nongnu.org, Eric Auger <eric.auger@redhat.com>,
eauger@redhat.com
Subject: [RESEND PATCH 1/2] hw/arm/virt: Rename default_bus_bypass_iommu
Date: Wed, 13 Oct 2021 17:06:07 +0100 [thread overview]
Message-ID: <20211013160607.649990-2-jean-philippe@linaro.org> (raw)
In-Reply-To: <20211013160607.649990-1-jean-philippe@linaro.org>
Since commit d8fb7d0969d5 ("vl: switch -M parsing to keyval"), machine
parameter definitions cannot use underscores, because keyval_dashify()
transforms them to dashes and the parser doesn't find the parameter.
This affects option default_bus_bypass_iommu which was introduced in the
same release:
$ qemu-system-aarch64 -M virt,default_bus_bypass_iommu=on
qemu-system-aarch64: Property 'virt-6.1-machine.default-bus-bypass-iommu' not found
Rename the parameter to "default-bus-bypass-iommu". Passing
"default_bus_bypass_iommu" is still valid since the underscore are
transformed automatically.
Fixes: 6d7a85483a06 ("hw/arm/virt: Add default_bus_bypass_iommu machine option")
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Tested-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
hw/arm/virt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 7170aaacd5..5fdd5aa888 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2687,10 +2687,10 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
"Set the IOMMU type. "
"Valid values are none and smmuv3");
- object_class_property_add_bool(oc, "default_bus_bypass_iommu",
+ object_class_property_add_bool(oc, "default-bus-bypass-iommu",
virt_get_default_bus_bypass_iommu,
virt_set_default_bus_bypass_iommu);
- object_class_property_set_description(oc, "default_bus_bypass_iommu",
+ object_class_property_set_description(oc, "default-bus-bypass-iommu",
"Set on/off to enable/disable "
"bypass_iommu for default root bus");
--
2.33.0
next prev parent reply other threads:[~2021-10-13 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 16:06 [RESEND PATCH 0/2] Fix machine parameter default_bus_bypass_iommu Jean-Philippe Brucker
2021-10-13 16:06 ` Jean-Philippe Brucker [this message]
2021-10-13 16:06 ` [RESEND PATCH 2/2] hw/i386: Rename default_bus_bypass_iommu Jean-Philippe Brucker
2021-10-22 14:46 ` Michael S. Tsirkin
2021-10-22 14:58 ` Jean-Philippe Brucker
2021-10-23 20:15 ` Michael S. Tsirkin
2021-10-22 12:23 ` [RESEND PATCH 0/2] Fix machine parameter default_bus_bypass_iommu Jean-Philippe Brucker
2021-10-22 12:33 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013160607.649990-2-jean-philippe@linaro.org \
--to=jean-philippe@linaro.org \
--cc=armbru@redhat.com \
--cc=eauger@redhat.com \
--cc=ehabkost@redhat.com \
--cc=eric.auger@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).