From: "Longpeng(Mike)" <longpeng2@huawei.com>
To: <alex.williamson@redhat.com>, <pbonzini@redhat.com>
Cc: "Longpeng\(Mike\)" <longpeng2@huawei.com>,
arei.gonglei@huawei.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org
Subject: [PATCH v4 4/6] kvm: irqchip: extract kvm_irqchip_add_deferred_msi_route
Date: Thu, 14 Oct 2021 08:48:50 +0800 [thread overview]
Message-ID: <20211014004852.1293-5-longpeng2@huawei.com> (raw)
In-Reply-To: <20211014004852.1293-1-longpeng2@huawei.com>
Extract a common helper that add MSI route for specific vector
but does not commit immediately.
Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
---
accel/kvm/kvm-all.c | 15 +++++++++++++--
include/sysemu/kvm.h | 6 ++++++
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index db8d83b..8627f7c 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -1953,7 +1953,7 @@ int kvm_irqchip_send_msi(KVMState *s, MSIMessage msg)
return kvm_set_irq(s, route->kroute.gsi, 1);
}
-int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev)
+int kvm_irqchip_add_deferred_msi_route(KVMState *s, int vector, PCIDevice *dev)
{
struct kvm_irq_routing_entry kroute = {};
int virq;
@@ -1996,7 +1996,18 @@ int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev)
kvm_add_routing_entry(s, &kroute);
kvm_arch_add_msi_route_post(&kroute, vector, dev);
- kvm_irqchip_commit_routes(s);
+
+ return virq;
+}
+
+int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev)
+{
+ int virq;
+
+ virq = kvm_irqchip_add_deferred_msi_route(s, vector, dev);
+ if (virq >= 0) {
+ kvm_irqchip_commit_routes(s);
+ }
return virq;
}
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index a1ab1ee..8de0d9a 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -476,6 +476,12 @@ void kvm_init_cpu_signals(CPUState *cpu);
* @return: virq (>=0) when success, errno (<0) when failed.
*/
int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev);
+/**
+ * Add MSI route for specific vector but does not commit to KVM
+ * immediately
+ */
+int kvm_irqchip_add_deferred_msi_route(KVMState *s, int vector,
+ PCIDevice *dev);
int kvm_irqchip_update_msi_route(KVMState *s, int virq, MSIMessage msg,
PCIDevice *dev);
void kvm_irqchip_commit_routes(KVMState *s);
--
1.8.3.1
next prev parent reply other threads:[~2021-10-14 0:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 0:48 [PATCH v4 0/6] optimize the downtime for vfio migration Longpeng(Mike)
2021-10-14 0:48 ` [PATCH v4 1/6] vfio: simplify the conditional statements in vfio_msi_enable Longpeng(Mike)
2021-10-14 0:48 ` [PATCH v4 2/6] vfio: move re-enabling INTX out of the common helper Longpeng(Mike)
2021-10-14 0:48 ` [PATCH v4 3/6] vfio: simplify the failure path in vfio_msi_enable Longpeng(Mike)
2021-10-14 0:48 ` Longpeng(Mike) [this message]
2021-10-14 0:48 ` [PATCH v4 5/6] Revert "vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration" Longpeng(Mike)
2021-10-14 0:48 ` [PATCH v4 6/6] vfio: defer to commit kvm irq routing when enable msi/msix Longpeng(Mike)
2021-10-21 20:51 ` Alex Williamson
2021-11-03 6:58 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014004852.1293-5-longpeng2@huawei.com \
--to=longpeng2@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).