qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [PATCH 0/3] Deprecate -watchdog, cleanup -watchdog-action
Date: Wed, 27 Oct 2021 15:12:36 +0200	[thread overview]
Message-ID: <20211027131239.802564-1-pbonzini@redhat.com> (raw)

-watchdog is a simple wrapper around -device, but it includes quite
a bit of code to register and list available watchdog devices.
Add a category for watchdogs so that they are listed as such in
'-device help', and deprecate it.

For -watchdog-action, make it 100% a shortcut for "-action watchdog",
instead of calling into watchdog.c from the command line parser.
This is a small improvement because "-watchdog-action" and "-action
watchdog" now override each other based on the position on the
command line; previously, "-action watchdog" always won.

Paolo Bonzini (3):
  watchdog: add information from -watchdog help to -device help
  vl: deprecate -watchdog
  watchdog: remove select_watchdog_action

 docs/about/deprecated.rst  |  5 +++++
 hw/watchdog/sbsa_gwdt.c    |  3 ++-
 hw/watchdog/watchdog.c     | 14 --------------
 hw/watchdog/wdt_aspeed.c   |  3 ++-
 hw/watchdog/wdt_diag288.c  |  3 ++-
 hw/watchdog/wdt_i6300esb.c |  3 ++-
 hw/watchdog/wdt_ib700.c    |  3 ++-
 hw/watchdog/wdt_imx2.c     |  4 ++--
 include/hw/qdev-core.h     |  1 +
 include/sysemu/watchdog.h  |  1 -
 monitor/misc.c             | 15 ++++++++++++---
 softmmu/qdev-monitor.c     |  1 +
 softmmu/vl.c               | 11 ++++++-----
 13 files changed, 37 insertions(+), 30 deletions(-)

-- 
2.31.1



             reply	other threads:[~2021-10-27 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 13:12 Paolo Bonzini [this message]
2021-10-27 13:12 ` [PATCH 1/3] watchdog: add information from -watchdog help to -device help Paolo Bonzini
2021-10-27 13:12 ` [PATCH 2/3] vl: deprecate -watchdog Paolo Bonzini
2021-10-27 13:12 ` [PATCH 3/3] watchdog: remove select_watchdog_action Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211027131239.802564-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).