From: Eduardo Habkost <ehabkost@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Eric Blake" <eblake@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Igor Mammedov" <imammedo@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v3 1/3] smbios: Rename SMBIOS_ENTRY_POINT_* enums
Date: Wed, 27 Oct 2021 10:23:29 -0400 [thread overview]
Message-ID: <20211027142329.lcsday3kbet6pplz@habkost.net> (raw)
In-Reply-To: <20211027034303-mutt-send-email-mst@kernel.org>
On Wed, Oct 27, 2021 at 03:43:43AM -0400, Michael S. Tsirkin wrote:
> On Tue, Oct 26, 2021 at 11:10:58AM -0400, Eduardo Habkost wrote:
> > Rename the enums to match the naming style used by QAPI, and to
> > use "32" and "64" instead of "20" and "31". This will allow us
> > to more easily move the enum to the QAPI schema later.
> >
> > About the naming choice: "SMBIOS 2.1 entry point"/"SMBIO 3.0
>
> typo in commit log
I'll fix it, thanks!
>
> > entry point" and "32-bit entry point"/"64-bit entry point" are
> > synonymous in the SMBIOS specification. However, the phrases
> > "32-bit entry point" and "64-bit entry point" are used more often.
> >
> > The new names also avoid confusion between the entry point format
> > and the actual SMBIOS version reported in the entry point
> > structure. For example: currently the 32-bit entry point
> > actually report SMBIOS 2.8 support, not 2.1.
> >
> > Based on portions of a patch submitted by Daniel P. Berrangé.
>
> I think you need the original S.O.B here too then.
I'm not sure it is appropriate here, as zero lines of code from
the original patch remain here.
>
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > First version of this code was submitted at:
> > https://lore.kernel.org/qemu-devel/20200908165438.1008942-5-berrange@redhat.com
> >
> > Changes from v2:
> > * Use "32" and "64" instead of "2_0" and "3_1"
> >
> > Changes from v1:
> > * Patch was split in two
> > * Hunks included this patch are not changed from v1
--
Eduardo
next prev parent reply other threads:[~2021-10-27 15:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:10 [PATCH v3 0/3] pc: Support configuration of SMBIOS entry point type Eduardo Habkost
2021-10-26 15:10 ` [PATCH v3 1/3] smbios: Rename SMBIOS_ENTRY_POINT_* enums Eduardo Habkost
2021-10-26 15:13 ` Philippe Mathieu-Daudé
2021-10-27 7:43 ` Michael S. Tsirkin
2021-10-27 14:23 ` Eduardo Habkost [this message]
2021-10-26 15:10 ` [PATCH v3 2/3] hw/smbios: Use qapi for SmbiosEntryPointType Eduardo Habkost
2021-10-26 15:14 ` Philippe Mathieu-Daudé
2021-11-03 10:03 ` Markus Armbruster
2021-10-26 15:11 ` [PATCH v3 3/3] hw/i386: expose a "smbios-entry-point-type" PC machine property Eduardo Habkost
2021-11-02 8:51 ` Philippe Mathieu-Daudé
2021-11-02 11:25 ` Michael S. Tsirkin
2021-11-10 22:06 ` Eduardo Habkost
2021-11-22 9:08 ` Gerd Hoffmann
2021-11-01 22:32 ` [PATCH v3 0/3] pc: Support configuration of SMBIOS entry point type Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027142329.lcsday3kbet6pplz@habkost.net \
--to=ehabkost@redhat.com \
--cc=ani@anisinha.ca \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).