From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: [PATCH v4 0/2] vhost: Fix last queue index of devices with no cvq
Date: Thu, 4 Nov 2021 09:56:23 +0100 [thread overview]
Message-ID: <20211104085625.2054959-1-eperezma@redhat.com> (raw)
The -1 assumes that cvq device model is accounted in data_queue_pairs,
if cvq does not exists, but it's actually the opposite: Devices with
!cvq are ok but devices with cvq does not add the last queue to
data_queue_pairs.
This is not a problem to vhost-net, but it is to vhost-vdpa:
* Devices with cvq gets initialized at last data vq device model, not
at cvq one.
* Devices with !cvq never gets initialized, since last_index is the
first queue of the last device model.
Tested with vp_vdpa with host's vhost=on and vhost=off, and ctrol_vq
on and off.
v4:
* Rename last_index to index_end
v3:
* Recover cvq devices.
* Rename last_index to last_vq_index
v2:
* Delete all the conditional code instead of ROUND_DOWN in a
deinitely too-bit-tricky way.
Eugenio Pérez (2):
vhost: Rename last_index to vq_index_end
vhost: Fix last vq queue index of devices with no cvq
include/hw/virtio/vhost.h | 4 ++--
hw/net/vhost_net.c | 12 ++++++------
hw/virtio/vhost-vdpa.c | 2 +-
3 files changed, 9 insertions(+), 9 deletions(-)
--
2.27.0
next reply other threads:[~2021-11-04 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 8:56 Eugenio Pérez [this message]
2021-11-04 8:56 ` [PATCH v4 1/2] vhost: Rename last_index to vq_index_end Eugenio Pérez
2021-11-06 11:49 ` Juan Quintela
2021-11-04 8:56 ` [PATCH v4 2/2] vhost: Fix last vq queue index of devices with no cvq Eugenio Pérez
2021-11-05 4:19 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104085625.2054959-1-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).