From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Dongwon Kim <dongwon.kim@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PULL 5/6] ui/gtk: gd_draw_event returns FALSE when no cairo surface is bound
Date: Fri, 5 Nov 2021 12:30:42 +0100 [thread overview]
Message-ID: <20211105113043.4059361-6-kraxel@redhat.com> (raw)
In-Reply-To: <20211105113043.4059361-1-kraxel@redhat.com>
From: Dongwon Kim <dongwon.kim@intel.com>
gd_draw_event shouldn't try to repaint if surface does not exist
for the VC.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Message-Id: <20211104065153.28897-4-dongwon.kim@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/gtk.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 8da673c18c72..d2892ea6b4a9 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -778,6 +778,9 @@ static gboolean gd_draw_event(GtkWidget *widget, cairo_t *cr, void *opaque)
if (!vc->gfx.ds) {
return FALSE;
}
+ if (!vc->gfx.surface) {
+ return FALSE;
+ }
vc->gfx.dcl.update_interval =
gd_monitor_update_interval(vc->window ? vc->window : s->window);
--
2.31.1
next prev parent reply other threads:[~2021-11-05 11:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 11:30 [PULL 0/6] Egl 20211105 patches Gerd Hoffmann
2021-11-05 11:30 ` [PULL 1/6] virtio-gpu: splitting one extended mode guest fb into n-scanouts Gerd Hoffmann
2021-11-05 11:30 ` [PULL 2/6] ui/gtk-egl: un-tab and re-tab should destroy egl surface and context Gerd Hoffmann
2021-11-05 11:30 ` [PULL 3/6] ui/gtk-egl: make sure the right context is set as the current Gerd Hoffmann
2021-11-05 11:30 ` [PULL 4/6] ui/gtk-egl: guest fb texture needs to be regenerated when reinitializing egl Gerd Hoffmann
2021-11-06 20:32 ` Laurent Vivier
2021-11-08 8:07 ` Philippe Mathieu-Daudé
2021-11-05 11:30 ` Gerd Hoffmann [this message]
2021-11-05 11:30 ` [PULL 6/6] ui/gtk-egl: blitting partial guest fb to the proper scanout surface Gerd Hoffmann
2021-11-05 17:13 ` [PULL 0/6] Egl 20211105 patches Richard Henderson
2021-11-05 18:26 ` Philippe Mathieu-Daudé
2021-11-05 18:49 ` Philippe Mathieu-Daudé
2021-11-08 8:12 ` Mark Cave-Ayland
2021-11-08 8:17 ` Philippe Mathieu-Daudé
2021-11-08 9:22 ` Daniel P. Berrangé
2021-11-08 9:36 ` Gerd Hoffmann
2021-11-08 9:37 ` Philippe Mathieu-Daudé
2021-11-08 9:41 ` Mark Cave-Ayland
2021-11-08 9:47 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105113043.4059361-6-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=dongwon.kim@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).