From: Yanan Wang <wangyanan55@huawei.com>
To: <qemu-devel@nongnu.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Andrew Jones" <drjones@redhat.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
wanghaibin.wang@huawei.com,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH 2/2] tests/unit/test-smp-parse: Fix a check-patch complain
Date: Wed, 10 Nov 2021 17:52:08 +0800 [thread overview]
Message-ID: <20211110095208.448-3-wangyanan55@huawei.com> (raw)
In-Reply-To: <20211110095208.448-1-wangyanan55@huawei.com>
Checkpatch.pl reports errors like below for commit 9e8e393bb7. Fix it.
ERROR: space required after that close brace '}'
+ SMPTestData *data = &(SMPTestData){{ }};
Fixes: 9e8e393bb7 ("tests/unit: Add an unit test for smp parsing")
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
---
tests/unit/test-smp-parse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index 872512aa37..3627fe61ad 100644
--- a/tests/unit/test-smp-parse.c
+++ b/tests/unit/test-smp-parse.c
@@ -514,7 +514,7 @@ static void test_generic(void)
Object *obj = smp_test_machine_init();
MachineState *ms = MACHINE(obj);
MachineClass *mc = MACHINE_GET_CLASS(obj);
- SMPTestData *data = &(SMPTestData){{ }};
+ SMPTestData *data = &(SMPTestData){ {0} };
int i;
for (i = 0; i < ARRAY_SIZE(data_generic_valid); i++) {
@@ -548,7 +548,7 @@ static void test_with_dies(void)
Object *obj = smp_test_machine_init();
MachineState *ms = MACHINE(obj);
MachineClass *mc = MACHINE_GET_CLASS(obj);
- SMPTestData *data = &(SMPTestData){{ }};
+ SMPTestData *data = &(SMPTestData){ {0} };
unsigned int num_dies = 2;
int i;
--
2.19.1
next prev parent reply other threads:[~2021-11-10 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 9:52 [PATCH 0/2] tests/unit/test-smp-parse: Two fixes for test-smp-parse Yanan Wang
2021-11-10 9:52 ` [PATCH 1/2] tests/unit/test-smp-parse: Make an unified name for the tested machine Yanan Wang
2021-11-10 9:52 ` Yanan Wang [this message]
2021-11-10 10:16 ` [PATCH 2/2] tests/unit/test-smp-parse: Fix a check-patch complain Markus Armbruster
2021-11-10 11:37 ` wangyanan (Y)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110095208.448-3-wangyanan55@huawei.com \
--to=wangyanan55@huawei.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).