From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org, "Alexander Bulekov" <alxndr@bu.edu>,
"Qiuhao Li" <Qiuhao.Li@outlook.com>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Bandan Das" <bsd@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Hannes Reinecke" <hare@suse.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH-for-6.2 2/2] tests/qtest/fuzz-megasas-test: Add test for GitLab issue #521
Date: Fri, 19 Nov 2021 21:11:41 +0100 [thread overview]
Message-ID: <20211119201141.532377-3-philmd@redhat.com> (raw)
In-Reply-To: <20211119201141.532377-1-philmd@redhat.com>
Without the previous commit, this test triggers:
$ make check-qtest-x86_64
[...]
Running test qtest-x86_64/fuzz-megasas-test
qemu-system-x86_64: softmmu/physmem.c:3229: address_space_unmap: Assertion `mr != NULL' failed.
Broken pipe
ERROR qtest-x86_64/fuzz-megasas-test - too few tests run (expected 2, got 1)
Suggested-by: Alexander Bulekov <alxndr@bu.edu>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
tests/qtest/fuzz-megasas-test.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/tests/qtest/fuzz-megasas-test.c b/tests/qtest/fuzz-megasas-test.c
index 940a76bf25a..e1141c58a4e 100644
--- a/tests/qtest/fuzz-megasas-test.c
+++ b/tests/qtest/fuzz-megasas-test.c
@@ -34,6 +34,34 @@ static void test_lp1878263_megasas_zero_iov_cnt(void)
qtest_quit(s);
}
+/*
+ * Overflow SGL buffer.
+ * https://gitlab.com/qemu-project/qemu/-/issues/521
+ */
+static void test_gitlab_issue521_megasas_sgl_ovf(void)
+{
+ QTestState *s = qtest_init("-display none -m 32M -machine q35 "
+ "-nodefaults -device megasas "
+ "-device scsi-cd,drive=null0 "
+ "-blockdev "
+ "driver=null-co,read-zeroes=on,node-name=null0");
+ qtest_outl(s, 0xcf8, 0x80000818);
+ qtest_outl(s, 0xcfc, 0xc000);
+ qtest_outl(s, 0xcf8, 0x80000804);
+ qtest_outw(s, 0xcfc, 0x05);
+ qtest_bufwrite(s, 0x0, "\x01", 0x1);
+ qtest_bufwrite(s, 0x7, "\x01", 0x1);
+ qtest_bufwrite(s, 0x10, "\x02", 0x1);
+ qtest_bufwrite(s, 0x16, "\x01", 0x1);
+ qtest_bufwrite(s, 0x28, "\x01", 0x1);
+ qtest_bufwrite(s, 0x33, "\x01", 0x1);
+ qtest_outb(s, 0xc040, 0x0);
+ qtest_outb(s, 0xc040, 0x20);
+ qtest_outl(s, 0xc040, 0x20000000);
+ qtest_outb(s, 0xc040, 0x20);
+ qtest_quit(s);
+}
+
int main(int argc, char **argv)
{
const char *arch = qtest_get_arch();
@@ -43,6 +71,8 @@ int main(int argc, char **argv)
if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
qtest_add_func("fuzz/test_lp1878263_megasas_zero_iov_cnt",
test_lp1878263_megasas_zero_iov_cnt);
+ qtest_add_func("fuzz/gitlab_issue521_megasas_sgl_ovf",
+ test_gitlab_issue521_megasas_sgl_ovf);
}
return g_test_run();
--
2.31.1
next prev parent reply other threads:[~2021-11-19 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 20:11 [PATCH-for-6.2 0/2] hw/scsi/megasas: Avoid overflowing the SGL buffer Philippe Mathieu-Daudé
2021-11-19 20:11 ` [PATCH-for-6.2 1/2] hw/scsi/megasas: Fails command if SGL buffer overflows Philippe Mathieu-Daudé
2021-11-19 20:11 ` Philippe Mathieu-Daudé [this message]
2021-11-22 11:17 ` [PATCH-for-6.2 0/2] hw/scsi/megasas: Avoid overflowing the SGL buffer Darren Kenny
2021-12-13 12:32 ` Philippe Mathieu-Daudé
2021-12-15 10:30 ` Philippe Mathieu-Daudé
2021-12-17 9:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119201141.532377-3-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=bsd@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=fam@euphon.net \
--cc=hare@suse.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).