From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77DB0C433FE for ; Mon, 22 Nov 2021 11:34:38 +0000 (UTC) Received: from localhost ([::1]:39402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mp7an-0005ws-F9 for qemu-devel@archiver.kernel.org; Mon, 22 Nov 2021 06:34:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp7a3-00050H-NH for qemu-devel@nongnu.org; Mon, 22 Nov 2021 06:33:51 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:25655) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mp7a2-0006po-GU for qemu-devel@nongnu.org; Mon, 22 Nov 2021 06:33:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637580829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uCAo8tNBYqjYbYU5JkoqonFteLnbw1SpFiI/f2ieGLc=; b=hcyiTbVOqlLtuL2GwV5+1TEfeMb4ak7O7wFUO0mGjHkwMHYl6+iLMfYiHNLCyabT8xhaO1 q9qedBpjCamSZvmhUOC1QdHzM0nI1gE4MrlI7D6rKfq3udxT198pOY1u8mrcPxZX2qI7dl iqDHfJMOUAmOeRNDlXQ98/uOqr9wVzo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-303-v9oPsqZUNpaX0kduzPgmMA-1; Mon, 22 Nov 2021 06:33:46 -0500 X-MC-Unique: v9oPsqZUNpaX0kduzPgmMA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B5F218799EC; Mon, 22 Nov 2021 11:33:44 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.234]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF02B5E274; Mon, 22 Nov 2021 11:33:26 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 95EF1180039D; Mon, 22 Nov 2021 10:08:15 +0100 (CET) Date: Mon, 22 Nov 2021 10:08:15 +0100 From: Gerd Hoffmann To: "Michael S. Tsirkin" Subject: Re: [PATCH v3 3/3] hw/i386: expose a "smbios-entry-point-type" PC machine property Message-ID: <20211122090815.2vjsh4vrp7cvqi7g@sirius.home.kraxel.org> References: <20211026151100.1691925-1-ehabkost@redhat.com> <20211026151100.1691925-4-ehabkost@redhat.com> <20211102072349-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: <20211102072349-mutt-send-email-mst@kernel.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.709, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Daniel P. Berrange" , Eduardo Habkost , Eric Blake , Richard Henderson , qemu-devel@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, Igor Mammedov , Ani Sinha , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Michael Roth Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Nov 02, 2021 at 07:25:25AM -0400, Michael S. Tsirkin wrote: > On Tue, Nov 02, 2021 at 09:51:35AM +0100, Philippe Mathieu-Daudé wrote: > > On 10/26/21 17:11, Eduardo Habkost wrote: > > > The i440fx and Q35 machine types are both hardcoded to use the > > > legacy SMBIOS 2.1 (32-bit) entry point. This is a sensible > > > conservative choice because SeaBIOS only supports SMBIOS 2.1 > > > > > > EDK2, however, can also support SMBIOS 3.0 (64-bit) entry points, > > > and QEMU already uses this on the ARM virt machine type. > > > > > > This adds a property to allow the choice of SMBIOS entry point > > > versions For example to opt in to 64-bit SMBIOS entry point: > > > > > > $QEMU -machine q35,smbios-entry-point-type=64 > > > > It would be nice to have a test for this... > > > > Otherwise, > > Reviewed-by: Philippe Mathieu-Daudé > > Can we update seabios and the switch the default? seabios support is unfortunately not yet merged upstream. > Maybe just for q35? > Or are there more considerations? It's a guest-visible change, so IMHO we need the runtime switch anyway so old machine types can continue to use the smbios 2.x entry point. We'll switch the default at some point for sure, but I don't think that'll happen for the 6.2 machine type. We are simply too late. take care, Gerd