From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"David Hildenbrand" <david@redhat.com>,
"Jason Wang" <jasowang@redhat.com>, "Li Qiang" <liq3ea@gmail.com>,
"Qiuhao Li" <Qiuhao.Li@outlook.com>,
"Peter Xu" <peterx@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
qemu-arm@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [RFC PATCH v3 0/3] physmem: Have flaview API check bus permission from MemTxAttrs argument
Date: Wed, 15 Dec 2021 19:24:18 +0100 [thread overview]
Message-ID: <20211215182421.418374-1-philmd@redhat.com> (raw)
This series aim to kill a recent class of bug, the infamous
"DMA reentrancy" issues found by Alexander while fuzzing.
Introduce the 'memory' field in MemTxAttrs, allowing to restrict
a controller to memories (and not devices).
If a transaction permission is not allowed (for example access
to device), we return the specific MEMTX_BUS_ERROR.
Permissions are checked in after the flatview is resolved, and
before the access is done, in a new function: flatview_access_allowed().
Since v2 [1]:
- Addressed review comments:
- reword arm_gicv3 description (pm215)
- merged patches 3/4/5 (peterx & dhildenb)
- simplify flatview_access_allowed() logic (stefanha)
- drop MEMTXPERM enum and reword following AMBA terminology (edgar)
Since v1 ("hw: Forbid DMA write accesses to MMIO regions") [2]:
- rewrite based on Peter / Stefan feedbacks
Based on "hw: Let the DMA API take a MemTxAttrs argument" [3].
Based-on: <20210702092439.989969-1-philmd@redhat.com>
[1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg831168.html
[2] https://www.mail-archive.com/qemu-block@nongnu.org/msg72924.html
[3] https://www.mail-archive.com/qemu-devel@nongnu.org/msg820359.html
Philippe Mathieu-Daudé (3):
hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR
softmmu/physmem: Simplify flatview_write and
address_space_access_valid
softmmu/physmem: Introduce MemTxAttrs::memory field and
MEMTX_BUS_ERROR
include/exec/memattrs.h | 9 +++++++
hw/intc/arm_gicv3_redist.c | 4 +--
softmmu/physmem.c | 54 +++++++++++++++++++++++++++++++-------
3 files changed, 55 insertions(+), 12 deletions(-)
--
2.33.1
next reply other threads:[~2021-12-15 19:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 18:24 Philippe Mathieu-Daudé [this message]
2021-12-15 18:24 ` [RFC PATCH v3 1/3] hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR Philippe Mathieu-Daudé
2022-01-19 17:34 ` Philippe Mathieu-Daudé via
2022-01-20 10:53 ` Peter Maydell
2021-12-15 18:24 ` [RFC PATCH v3 2/3] softmmu/physmem: Simplify flatview_write and address_space_access_valid Philippe Mathieu-Daudé
2021-12-15 18:24 ` [RFC PATCH v3 3/3] softmmu/physmem: Introduce MemTxAttrs::memory field and MEMTX_BUS_ERROR Philippe Mathieu-Daudé
2021-12-17 19:46 ` Richard Henderson
2021-12-17 22:34 ` Peter Maydell
2021-12-17 23:18 ` Philippe Mathieu-Daudé
2021-12-18 2:07 ` Richard Henderson
2021-12-18 11:26 ` Philippe Mathieu-Daudé
2022-01-24 16:16 ` Stefan Hajnoczi
2022-01-24 16:30 ` [RFC PATCH v3 0/3] physmem: Have flaview API check bus permission from MemTxAttrs argument Stefan Hajnoczi
2022-01-24 16:50 ` Alexander Bulekov
2022-01-25 11:51 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211215182421.418374-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).