From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C654C433F5 for ; Wed, 9 Feb 2022 18:23:18 +0000 (UTC) Received: from localhost ([::1]:42022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nHrcb-00011g-L8 for qemu-devel@archiver.kernel.org; Wed, 09 Feb 2022 13:23:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHrXo-0005MS-0a for qemu-devel@nongnu.org; Wed, 09 Feb 2022 13:18:21 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nHrXj-0007vf-2L for qemu-devel@nongnu.org; Wed, 09 Feb 2022 13:18:19 -0500 Received: from fraeml715-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Jv7LC68jmz67tt6; Thu, 10 Feb 2022 02:13:55 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml715-chm.china.huawei.com (10.206.15.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 9 Feb 2022 19:18:04 +0100 Received: from localhost (10.122.247.231) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 9 Feb 2022 18:18:03 +0000 Date: Wed, 9 Feb 2022 18:18:01 +0000 To: , Marcel Apfelbaum , "Michael S . Tsirkin" , Igor Mammedov CC: , Ben Widawsky , Alex =?ISO-8859-1?Q?Benn=E9e?= , Peter Maydell , , "Shameerali Kolothum Thodi" , Philippe =?ISO-8859-1?Q?Mat?= =?ISO-8859-1?Q?hieu-Daud=E9?= , Saransh Gupta1 , Shreyas Shah , Chris Browy , Samarth Saxena , "Dan Williams" Subject: Re: [PATCH v4 23/42] tests/acpi: allow CEDT table addition Message-ID: <20220209181801.00000e4d@huawei.com> In-Reply-To: <20220124171705.10432-24-Jonathan.Cameron@huawei.com> References: <20220124171705.10432-1-Jonathan.Cameron@huawei.com> <20220124171705.10432-24-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies R&D (UK) Ltd. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhreml743-chm.china.huawei.com (10.201.108.193) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Jonathan Cameron From: Jonathan Cameron via On Mon, 24 Jan 2022 17:16:46 +0000 Jonathan Cameron wrote: > From: Ben Widawsky > > Following patches will add a new ACPI table, the > CXL Early Discovery Table (CEDT). > > Signed-off-by: Ben Widawsky > Signed-off-by: Jonathan Cameron > --- > tests/data/acpi/pc/CEDT | 0 > tests/data/acpi/q35/CEDT | 0 > tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ > 3 files changed, 2 insertions(+) > > diff --git a/tests/data/acpi/pc/CEDT b/tests/data/acpi/pc/CEDT > new file mode 100644 > index 0000000000..e69de29bb2 > diff --git a/tests/data/acpi/q35/CEDT b/tests/data/acpi/q35/CEDT > new file mode 100644 > index 0000000000..e69de29bb2 > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h > index dfb8523c8b..9b07f1e1ff 100644 > --- a/tests/qtest/bios-tables-test-allowed-diff.h > +++ b/tests/qtest/bios-tables-test-allowed-diff.h > @@ -1 +1,3 @@ > /* List of comma-separated changed AML files to ignore */ > +"tests/data/acpi/pc/CEDT", > +"tests/data/acpi/q35/CEDT", Whilst reordering the series to allow partial sets to be picked up it occurred to me that there is reason why we should now generate a CEDT table unless cxl=on is set for the relevant machine. Adding the relevant conditions means we can avoid this dance to add effectively empty CEDT tables. I have added a proper test for to bios-test-tables but that can be introduced once everything is in place, rather than as we go along (whereas for qtests/cxl-test.c I am doing a series of updates as the functionality is built up.). Makes for a simpler patch series to update. Jonathan