From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, hreitz@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [PATCH 02/26] qcow2: remove incorrect coroutine_fn annotations
Date: Tue, 19 Apr 2022 13:07:19 -0500 [thread overview]
Message-ID: <20220419180643.hhzredj3qfazd4a3@redhat.com> (raw)
In-Reply-To: <20220415131900.793161-3-pbonzini@redhat.com>
On Fri, Apr 15, 2022 at 03:18:36PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Again, a sentence on why this is correct would be helpful.
> block/qcow2-refcount.c | 4 ++--
> block/qcow2.h | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index b91499410c..b6f90b2702 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -1206,7 +1206,7 @@ void qcow2_free_any_cluster(BlockDriverState *bs, uint64_t l2_entry,
> }
> }
>
> -int coroutine_fn qcow2_write_caches(BlockDriverState *bs)
> +int qcow2_write_caches(BlockDriverState *bs)
> {
> BDRVQcow2State *s = bs->opaque;
> int ret;
> @@ -1226,7 +1226,7 @@ int coroutine_fn qcow2_write_caches(BlockDriverState *bs)
> return 0;
> }
>
> -int coroutine_fn qcow2_flush_caches(BlockDriverState *bs)
> +int qcow2_flush_caches(BlockDriverState *bs)
> {
> int ret = qcow2_write_caches(bs);
Both of these eventually hit qcow2_cache_write, which is not marked
coroutine, so these should not be either.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2022-04-19 18:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 13:18 [PATCH 00/19] block: fix coroutine_fn annotations Paolo Bonzini
2022-04-15 13:18 ` [PATCH 01/26] block: remove incorrect " Paolo Bonzini
2022-04-19 17:57 ` Eric Blake
2022-04-21 10:21 ` Stefan Hajnoczi
2022-04-15 13:18 ` [PATCH 02/26] qcow2: " Paolo Bonzini
2022-04-19 18:07 ` Eric Blake [this message]
2022-04-21 10:24 ` Stefan Hajnoczi
2022-04-27 12:36 ` Paolo Bonzini
2022-04-27 14:18 ` Paolo Bonzini
2022-04-15 13:18 ` [PATCH 03/26] nbd: " Paolo Bonzini
2022-04-19 18:08 ` Eric Blake
2022-04-20 14:07 ` Paolo Bonzini
2022-04-15 13:18 ` [PATCH 04/26] coroutine: " Paolo Bonzini
2022-04-19 18:25 ` Eric Blake
2022-04-21 10:26 ` Stefan Hajnoczi
2022-04-15 13:18 ` [PATCH 05/26] blkdebug: add missing " Paolo Bonzini
2022-04-19 18:46 ` Eric Blake
2022-04-15 13:18 ` [PATCH 06/26] blkverify: " Paolo Bonzini
2022-04-19 18:47 ` Eric Blake
2022-04-15 13:18 ` [PATCH 07/26] block: " Paolo Bonzini
2022-04-19 18:50 ` Eric Blake
2022-04-20 14:08 ` Paolo Bonzini
2022-04-15 13:18 ` [PATCH 08/26] file-posix: " Paolo Bonzini
2022-04-19 19:30 ` Eric Blake
2022-04-15 13:18 ` [PATCH 09/26] iscsi: " Paolo Bonzini
2022-04-19 19:43 ` Eric Blake
2022-04-15 13:18 ` [PATCH 10/26] nbd: " Paolo Bonzini
2022-04-26 20:26 ` Eric Blake
2022-04-15 13:18 ` [PATCH 11/26] nfs: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 12/26] nvme: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 13/26] parallels: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 14/26] qcow2: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 15/26] copy-before-write: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 16/26] curl: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 17/26] qed: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 18/26] quorum: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 19/26] throttle: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 20/26] vmdk: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 21/26] job: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 22/26] coroutine-lock: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 23/26] raw-format: " Paolo Bonzini
2022-04-15 13:18 ` [PATCH 24/26] 9p: " Paolo Bonzini
2022-04-18 11:08 ` Christian Schoenebeck
2022-04-15 13:18 ` [PATCH 25/26] migration: " Paolo Bonzini
2022-04-15 13:19 ` [PATCH 26/26] test-coroutine: " Paolo Bonzini
2022-04-21 10:35 ` [PATCH 00/19] block: fix " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220419180643.hhzredj3qfazd4a3@redhat.com \
--to=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).