From: Greg Kurz <groug@kaod.org>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org,
Keno Fischer <keno@juliacomputing.com>,
Michael Roitzsch <reactorcontrol@icloud.com>,
Will Cohen <wwcohen@gmail.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: Re: [PATCH 5/5] 9pfs: fix removing non-existent POSIX ACL xattr on macOS host
Date: Thu, 21 Apr 2022 10:26:11 +0200 [thread overview]
Message-ID: <20220421102611.5a2a0564@bahia> (raw)
In-Reply-To: <284de6154d7ad57ac6539a7318aa2364261da105.1650370027.git.qemu_oss@crudebyte.com>
On Tue, 19 Apr 2022 13:43:30 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> When mapped POSIX ACL is used, we are ignoring errors when trying
> to remove a POSIX ACL xattr that does not exist. On Linux hosts we
> would get ENODATA in such cases, on macOS hosts however we get
> ENOATTR instead, so ignore ENOATTR errors as well.
>
> This patch fixes e.g. a command on Linux guest like:
>
> cp --preserve=mode old new
>
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
> hw/9pfs/9p-posix-acl.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/9p-posix-acl.c b/hw/9pfs/9p-posix-acl.c
> index eadae270dd..2bf155f941 100644
> --- a/hw/9pfs/9p-posix-acl.c
> +++ b/hw/9pfs/9p-posix-acl.c
> @@ -65,7 +65,13 @@ static int mp_pacl_removexattr(FsContext *ctx,
> int ret;
>
> ret = local_removexattr_nofollow(ctx, path, MAP_ACL_ACCESS);
> - if (ret == -1 && errno == ENODATA) {
> + if (ret == -1 &&
> + (errno == ENODATA
> +#ifdef ENOATTR
> + || errno == ENOATTR
> +#endif
> + )
We already have this in <qemu/xattr.h> which is included by
9p-posix-acl.c :
/*
* Modern distributions (e.g. Fedora 15), have no libattr.so, place attr.h
* in /usr/include/sys, and don't have ENOATTR.
*/
#ifdef CONFIG_LIBATTR
# include <attr/xattr.h>
#else
# if !defined(ENOATTR)
# define ENOATTR ENODATA
# endif
# include <sys/xattr.h>
#endif
I guess this patch could just s/ENODATA/ENOATTR/ to avoid the
extra ifdefery.
> + ) {
> /*
> * We don't get ENODATA error when trying to remove a
> * posix acl that is not present. So don't throw the error
next prev parent reply other threads:[~2022-04-21 9:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 12:07 [PATCH 0/5] 9pfs: macOS host fixes Christian Schoenebeck
2022-04-19 11:40 ` [PATCH 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS Christian Schoenebeck
2022-04-19 13:44 ` Will Cohen
2022-04-20 2:03 ` Akihiko Odaki
2022-04-20 8:40 ` Greg Kurz
2022-04-20 9:38 ` Christian Schoenebeck
2022-04-19 11:41 ` [PATCH 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) " Christian Schoenebeck
2022-04-19 13:46 ` Will Cohen
2022-04-20 9:09 ` Greg Kurz
2022-04-20 10:28 ` Christian Schoenebeck
2022-04-20 12:08 ` Greg Kurz
2022-04-20 12:10 ` Greg Kurz
2022-04-20 12:41 ` Christian Schoenebeck
2022-04-19 11:41 ` [PATCH 3/5] 9pfs: fix wrong encoding of rdev field in Rgetattr " Christian Schoenebeck
2022-04-21 7:30 ` Greg Kurz
2022-04-21 10:25 ` Christian Schoenebeck
2022-04-21 10:31 ` Greg Kurz
2022-04-19 11:41 ` [PATCH 4/5] 9pfs: fix wrong errno being sent to Linux client on macOS host Christian Schoenebeck
2022-04-21 10:48 ` Greg Kurz
2022-04-21 11:13 ` Christian Schoenebeck
2022-04-21 11:46 ` Greg Kurz
2022-04-21 12:20 ` Christian Schoenebeck
2022-04-19 11:43 ` [PATCH 5/5] 9pfs: fix removing non-existent POSIX ACL xattr " Christian Schoenebeck
2022-04-21 8:26 ` Greg Kurz [this message]
2022-04-21 10:55 ` Christian Schoenebeck
2022-04-21 12:26 ` Greg Kurz
2022-04-21 13:03 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421102611.5a2a0564@bahia \
--to=groug@kaod.org \
--cc=akihiko.odaki@gmail.com \
--cc=keno@juliacomputing.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=reactorcontrol@icloud.com \
--cc=wwcohen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).