From: Greg Kurz <groug@kaod.org>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org,
Keno Fischer <keno@juliacomputing.com>,
Michael Roitzsch <reactorcontrol@icloud.com>,
Will Cohen <wwcohen@gmail.com>,
Akihiko Odaki <akihiko.odaki@gmail.com>
Subject: Re: [PATCH v2 4/5] 9pfs: fix wrong errno being sent to Linux client on macOS host
Date: Thu, 21 Apr 2022 18:39:37 +0200 [thread overview]
Message-ID: <20220421183937.21531b9a@bahia> (raw)
In-Reply-To: <eee249e308d99bb72ede83fef7bb7dc5a54ec43e.1650553693.git.qemu_oss@crudebyte.com>
On Thu, 21 Apr 2022 17:07:49 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> Linux and macOS only share some errno definitions with equal macro
> name and value. In fact most mappings for errno are completely
> different on the two systems.
>
> This patch converts some important errno values from macOS host to
> corresponding Linux errno values before eventually sending such error
> codes along with 'Rlerror' replies (if 9p2000.L is used that is). Not
> having translated errnos before violated the 9p2000.L protocol spec,
> which says:
>
> "
> size[4] Rlerror tag[2] ecode[4]
>
> ... ecode is a numerical Linux errno.
> "
>
> https://github.com/chaos/diod/wiki/protocol#lerror----return-error-code
>
> This patch fixes a bunch of misbehaviours when running a Linux client
> on macOS host. For instance this patch fixes:
>
> mount -t 9p -o posixacl ...
>
> on Linux guest if security_mode=mapped was used for 9p server, which
> refused to mount successfully, because macOS returned ENOATTR==93
> when client tried to retrieve POSIX ACL xattrs, because errno 93
> is defined as EPROTONOSUPPORT==93 on Linux, so Linux client believed
> that xattrs were not supported by filesystem on host in general.
>
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> Link: https://lore.kernel.org/qemu-devel/20220421124835.3e664669@bahia/
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> hw/9pfs/9p-util.h | 30 ++++++++++++++++++++++++++++++
> hw/9pfs/9p.c | 2 ++
> 2 files changed, 32 insertions(+)
>
> diff --git a/hw/9pfs/9p-util.h b/hw/9pfs/9p-util.h
> index 2cc9a5dbfb..c3526144c9 100644
> --- a/hw/9pfs/9p-util.h
> +++ b/hw/9pfs/9p-util.h
> @@ -58,6 +58,36 @@ static inline uint64_t host_dev_to_dotl_dev(dev_t dev)
> #endif
> }
>
> +/* Translates errno from host -> Linux if needed */
> +static inline int errno_to_dotl(int err) {
> +#if defined(CONFIG_LINUX)
> + /* nothing to translate (Linux -> Linux) */
> +#elif defined(CONFIG_DARWIN)
> + /*
> + * translation mandatory for macOS hosts
> + *
> + * FIXME: Only most important errnos translated here yet, this should be
> + * extended to as many errnos being translated as possible in future.
> + */
> + if (err == ENAMETOOLONG) {
> + err = 36; /* ==ENAMETOOLONG on Linux */
> + } else if (err == ENOTEMPTY) {
> + err = 39; /* ==ENOTEMPTY on Linux */
> + } else if (err == ELOOP) {
> + err = 40; /* ==ELOOP on Linux */
> + } else if (err == ENOATTR) {
> + err = 61; /* ==ENODATA on Linux */
> + } else if (err == ENOTSUP) {
> + err = 95; /* ==EOPNOTSUPP on Linux */
> + } else if (err == EOPNOTSUPP) {
> + err = 95; /* ==EOPNOTSUPP on Linux */
> + }
> +#else
> +#error Missing errno translation to Linux for this host system
> +#endif
> + return err;
> +}
> +
> #ifdef CONFIG_DARWIN
> #define qemu_fgetxattr(...) fgetxattr(__VA_ARGS__, 0, 0)
> #define qemu_lgetxattr(...) getxattr(__VA_ARGS__, 0, XATTR_NOFOLLOW)
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 4a296a0b94..0cd0c14c2a 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -1054,6 +1054,8 @@ static void coroutine_fn pdu_complete(V9fsPDU *pdu, ssize_t len)
> }
> len += ret;
> id = P9_RERROR;
> + } else {
> + err = errno_to_dotl(err);
> }
>
> ret = pdu_marshal(pdu, len, "d", err);
next prev parent reply other threads:[~2022-04-21 17:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 15:08 [PATCH v2 0/5] 9pfs: macOS host fixes Christian Schoenebeck
2022-04-21 15:07 ` [PATCH v2 1/5] 9pfs: fix qemu_mknodat(S_IFREG) on macOS Christian Schoenebeck
2022-04-21 16:32 ` Greg Kurz
2022-04-21 15:07 ` [PATCH v2 2/5] 9pfs: fix qemu_mknodat(S_IFSOCK) " Christian Schoenebeck
2022-04-21 16:36 ` Greg Kurz
2022-04-21 17:29 ` Christian Schoenebeck
2022-04-22 2:43 ` Akihiko Odaki
2022-04-22 14:06 ` Christian Schoenebeck
2022-04-23 4:33 ` Akihiko Odaki
2022-04-24 18:45 ` Christian Schoenebeck
2022-04-26 3:57 ` Akihiko Odaki
2022-04-26 12:38 ` Greg Kurz
2022-04-27 2:27 ` Akihiko Odaki
2022-04-27 10:18 ` Greg Kurz
2022-04-27 12:32 ` Christian Schoenebeck
2022-04-27 13:31 ` Greg Kurz
2022-04-27 16:18 ` Christian Schoenebeck
2022-04-27 17:12 ` Will Cohen
2022-04-27 18:16 ` Christian Schoenebeck
2022-04-27 17:37 ` Greg Kurz
2022-04-27 18:36 ` Christian Schoenebeck
2022-04-21 15:07 ` [PATCH v2 3/5] 9pfs: fix wrong encoding of rdev field in Rgetattr " Christian Schoenebeck
2022-04-21 16:39 ` Greg Kurz
2022-04-21 15:07 ` [PATCH v2 4/5] 9pfs: fix wrong errno being sent to Linux client on macOS host Christian Schoenebeck
2022-04-21 16:39 ` Greg Kurz [this message]
2022-04-21 15:07 ` [PATCH v2 5/5] 9pfs: fix removing non-existent POSIX ACL xattr " Christian Schoenebeck
2022-04-21 16:40 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220421183937.21531b9a@bahia \
--to=groug@kaod.org \
--cc=akihiko.odaki@gmail.com \
--cc=keno@juliacomputing.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=reactorcontrol@icloud.com \
--cc=wwcohen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).