From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 731C9C54EE9 for ; Fri, 16 Sep 2022 10:02:40 +0000 (UTC) Received: from localhost ([::1]:39838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ8BD-0005S0-1I for qemu-devel@archiver.kernel.org; Fri, 16 Sep 2022 06:02:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ87n-0003He-Q9 for qemu-devel@nongnu.org; Fri, 16 Sep 2022 05:59:07 -0400 Received: from mga04.intel.com ([192.55.52.120]:62386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ87Y-0003cm-4u for qemu-devel@nongnu.org; Fri, 16 Sep 2022 05:59:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663322332; x=1694858332; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=12OZBcnGODAmYZ+AQhyX6U0d1a9s5HIpAjq3AWPtWJs=; b=CwIWSkPvc0Y9w7eOjFJ0inBos9AcSAaBc1imjj8BzTRaR3Y0Eb3vHk0a 7qIoOL/9zC6QTswozOq3nnvRLeJLlqggET8AJrmNoBaJ2BaD+VMzQbI8r G9VCfOiG3J6qZEYnb+gt4JD800Fx5Tp2ffp8tWVwOiLn8Xi3Oq79xqQ8w j159NqnmX61yH3vAHhzrd2J17eJ6GnyaYUS7Hs9PFDbsiK/deXXDqr9S3 VH0M6wtZwZh5bIJn/lUKto1eTK+1pDwMRjDnl3WkHazJaDCjN0Z3IcaXA ePzUYivJvGIi/KFScmKbtMw0xxbuxTalT5g7CzgvAIEA7mDrUPU5r4knb w==; X-IronPort-AV: E=McAfee;i="6500,9779,10471"; a="297681443" X-IronPort-AV: E=Sophos;i="5.93,320,1654585200"; d="scan'208";a="297681443" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Sep 2022 02:58:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,320,1654585200"; d="scan'208";a="620036603" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by fmsmga007.fm.intel.com with ESMTP; 16 Sep 2022 02:58:21 -0700 Date: Fri, 16 Sep 2022 17:53:42 +0800 From: Chao Peng To: Bagas Sanjaya Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , Michael Roth , mhocko@suse.com, Muchun Song , wei.w.wang@intel.com Subject: Re: [PATCH v8 2/8] KVM: Extend the memslot to support fd-based private memory Message-ID: <20220916095342.GA2261402@chaop.bj.intel.com> References: <20220915142913.2213336-1-chao.p.peng@linux.intel.com> <20220915142913.2213336-3-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: none client-ip=192.55.52.120; envelope-from=chao.p.peng@linux.intel.com; helo=mga04.intel.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Chao Peng Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 16, 2022 at 04:14:29PM +0700, Bagas Sanjaya wrote: > On Thu, Sep 15, 2022 at 10:29:07PM +0800, Chao Peng wrote: > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > > index abd7c32126ce..c1fac1e9f820 100644 > > --- a/Documentation/virt/kvm/api.rst > > +++ b/Documentation/virt/kvm/api.rst > > @@ -1319,7 +1319,7 @@ yet and must be cleared on entry. > > :Capability: KVM_CAP_USER_MEMORY > > :Architectures: all > > :Type: vm ioctl > > -:Parameters: struct kvm_userspace_memory_region (in) > > +:Parameters: struct kvm_userspace_memory_region(_ext) (in) > > :Returns: 0 on success, -1 on error > > > > :: > > @@ -1332,9 +1332,18 @@ yet and must be cleared on entry. > > __u64 userspace_addr; /* start of the userspace allocated memory */ > > }; > > > > + struct kvm_userspace_memory_region_ext { > > + struct kvm_userspace_memory_region region; > > + __u64 private_offset; > > + __u32 private_fd; > > + __u32 pad1; > > + __u64 pad2[14]; > > + }; > > + > > /* for kvm_memory_region::flags */ > > #define KVM_MEM_LOG_DIRTY_PAGES (1UL << 0) > > #define KVM_MEM_READONLY (1UL << 1) > > + #define KVM_MEM_PRIVATE (1UL << 2) > > > > This ioctl allows the user to create, modify or delete a guest physical > > memory slot. Bits 0-15 of "slot" specify the slot id and this value > > @@ -1365,12 +1374,27 @@ It is recommended that the lower 21 bits of guest_phys_addr and userspace_addr > > be identical. This allows large pages in the guest to be backed by large > > pages in the host. > > > > -The flags field supports two flags: KVM_MEM_LOG_DIRTY_PAGES and > > -KVM_MEM_READONLY. The former can be set to instruct KVM to keep track of > > -writes to memory within the slot. See KVM_GET_DIRTY_LOG ioctl to know how to > > -use it. The latter can be set, if KVM_CAP_READONLY_MEM capability allows it, > > -to make a new slot read-only. In this case, writes to this memory will be > > -posted to userspace as KVM_EXIT_MMIO exits. > > +kvm_userspace_memory_region_ext includes all the kvm_userspace_memory_region > > +fields. It also includes additional fields for some specific features. See > > +below description of flags field for more information. It's recommended to use > > +kvm_userspace_memory_region_ext in new userspace code. > > Better say "kvm_userspace_memory_region_ext includes all fields of > kvm_userspace_memory_region struct, while also adds additional fields ..." > > > + > > +The flags field supports below flags: > > s/below/following/ > > > + > > +- KVM_MEM_LOG_DIRTY_PAGES can be set to instruct KVM to keep track of writes to > > + memory within the slot. See KVM_GET_DIRTY_LOG ioctl to know how to use it. > > + > > Better say "... For more details, see KVM_GET_DIRTY_LOG." > > > +- KVM_MEM_READONLY can be set, if KVM_CAP_READONLY_MEM capability allows it, to > > + make a new slot read-only. In this case, writes to this memory will be posted > > + to userspace as KVM_EXIT_MMIO exits. > > + > > Better say "if KVM_CAP_READONLY_MEM allows, KVM_MEM_READONLY makes a new > slot read-only ..." > > > +- KVM_MEM_PRIVATE can be set to indicate a new slot has private memory backed by > > + a file descirptor(fd) and the content of the private memory is invisible to > > + userspace. In this case, userspace should use private_fd/private_offset in > > + kvm_userspace_memory_region_ext to instruct KVM to provide private memory to > > + guest. Userspace should guarantee not to map the same pfn indicated by > > + private_fd/private_offset to different gfns with multiple memslots. Failed to > > + do this may result undefined behavior. > > > > For the lists above, > s/can be set/ It all looks good, thanks! > > Thanks. > > -- > An old man doll... just what I always wanted! - Clara