qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Robert Hoo <robert.hu@linux.intel.com>
To: imammedo@redhat.com, mst@redhat.com,
	xiaoguangrong.eric@gmail.com, ani@anisinha.ca,
	jingqi.liu@intel.com
Cc: qemu-devel@nongnu.org, robert.hu@intel.com,
	Robert Hoo <robert.hu@linux.intel.com>
Subject: [PATCH v4 3/5] acpi/nvdimm: define macro for NVDIMM Device _DSM
Date: Thu, 22 Sep 2022 20:21:53 +0800	[thread overview]
Message-ID: <20220922122155.1326543-4-robert.hu@linux.intel.com> (raw)
In-Reply-To: <20220922122155.1326543-1-robert.hu@linux.intel.com>

Since it will be heavily used in next patch, define macro
NVDIMM_DEVICE_DSM_UUID for "4309AC30-0D11-11E4-9191-0800200C9A66", which is
NVDIMM device specific method uuid defined in NVDIMM _DSM interface spec,
Section 3. [1]

No functional changes in this patch.

[1] https://pmem.io/documents/IntelOptanePMem_DSM_Interface-V2.0.pdf

Signed-off-by: Robert Hoo <robert.hu@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
 hw/acpi/nvdimm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/acpi/nvdimm.c b/hw/acpi/nvdimm.c
index 201317c611..afff911c1e 100644
--- a/hw/acpi/nvdimm.c
+++ b/hw/acpi/nvdimm.c
@@ -922,6 +922,7 @@ void nvdimm_init_acpi_state(NVDIMMState *state, MemoryRegion *io,
 #define NVDIMM_DSM_RFIT_STATUS  "RSTA"
 
 #define NVDIMM_QEMU_RSVD_UUID   "648B9CF2-CDA1-4312-8AD9-49C4AF32BD62"
+#define NVDIMM_DEVICE_DSM_UUID  "4309AC30-0D11-11E4-9191-0800200C9A66"
 
 static void nvdimm_build_common_dsm(Aml *dev,
                                     NVDIMMState *nvdimm_state)
@@ -1029,8 +1030,7 @@ static void nvdimm_build_common_dsm(Aml *dev,
                /* UUID for QEMU internal use */), expected_uuid));
     aml_append(elsectx, ifctx);
     elsectx2 = aml_else();
-    aml_append(elsectx2, aml_store(
-               aml_touuid("4309AC30-0D11-11E4-9191-0800200C9A66")
+    aml_append(elsectx2, aml_store(aml_touuid(NVDIMM_DEVICE_DSM_UUID)
                /* UUID for NVDIMM Devices */, expected_uuid));
     aml_append(elsectx, elsectx2);
     aml_append(method, elsectx);
-- 
2.31.1



  parent reply	other threads:[~2022-09-22 13:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-22 12:21 [PATCH v4 0/5] Support ACPI NVDIMM Label Methods Robert Hoo
2022-09-22 12:21 ` [PATCH v4 1/5] tests/acpi: allow SSDT changes Robert Hoo
2022-09-22 12:21 ` [PATCH v4 2/5] acpi/ssdt: Fix aml_or() and aml_and() in if clause Robert Hoo
2022-09-22 12:21 ` Robert Hoo [this message]
2022-09-22 12:21 ` [PATCH v4 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods Robert Hoo
2022-10-20 11:45   ` Igor Mammedov
2022-09-22 12:21 ` [PATCH v4 5/5] test/acpi/bios-tables-test: SSDT: update golden master binaries Robert Hoo
2022-09-22 12:29   ` Robert Hoo
2022-09-26 13:22     ` Igor Mammedov
2022-09-27  0:30       ` Robert Hoo
2022-10-07 13:27         ` Robert Hoo
2022-10-20  0:48           ` Robert Hoo
2022-10-20 11:48             ` Igor Mammedov
2022-10-20 12:01               ` Michael S. Tsirkin
2022-10-20 13:11                 ` Igor Mammedov
2022-10-26 14:45   ` Michael S. Tsirkin
2022-10-27  0:49     ` Robert Hoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220922122155.1326543-4-robert.hu@linux.intel.com \
    --to=robert.hu@linux.intel.com \
    --cc=ani@anisinha.ca \
    --cc=imammedo@redhat.com \
    --cc=jingqi.liu@intel.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=robert.hu@intel.com \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).