From: Gerd Hoffmann <kraxel@redhat.com>
To: Dario Faggioli <dfaggioli@suse.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH v2] pc: q35: Bump max_cpus to 1024
Date: Fri, 18 Nov 2022 10:43:18 +0100 [thread overview]
Message-ID: <20221118094318.l7mpuk56jfnjaxpc@sirius.home.kraxel.org> (raw)
In-Reply-To: <166876173513.24238.8968021290016401421.stgit@tumbleweed.Wayrath>
On Fri, Nov 18, 2022 at 09:55:35AM +0100, Dario Faggioli wrote:
> Keep the old limit of 288 for machine versions 7.2 and earlier.
>
> Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Eduardo Habkost <eduardo@habkost.net>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> ---
> Changes from v1:
> - fix actually keeping the old max value for the 7.2 machine type,
> which was the original goal, but was done wrongly
>
> ---
> This is related to:
>
> https://lore.kernel.org/qemu-devel/c705d0d8d6ed1a520b1ff92cb2f83fef19522d30.camel@suse.com/
>
> With this applied to QEMU, I've been able to start a VM with as high as
> 980 vCPUs (even if I was on an host with 384 pCPUs, so everything was
> super slow!). After that, I started to see messages like this:
>
> "SMBIOS 2.1 table length 66822 exceeds 65535"
We finally have smbios 3.0 support in both seabios and edk2, so we can
use that to avoid problems like this. So when raising the limits for
new machine types we should also flip the smbios default to 3.0.
take care,
Gerd
next prev parent reply other threads:[~2022-11-18 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 8:55 [PATCH v2] pc: q35: Bump max_cpus to 1024 Dario Faggioli
2022-11-18 9:18 ` Daniel P. Berrangé
2022-11-18 9:43 ` Gerd Hoffmann [this message]
2023-05-31 22:51 Suravee Suthikulpanit
2023-06-01 10:09 ` Joao Martins
2023-06-01 10:17 ` Daniel P. Berrangé
2023-06-01 11:03 ` Gerd Hoffmann
2023-06-01 11:09 ` Michael S. Tsirkin
2023-06-01 21:54 ` Suthikulpanit, Suravee
2023-06-02 8:43 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221118094318.l7mpuk56jfnjaxpc@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=dfaggioli@suse.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).