From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: si-wei.liu@oracle.com, Liuxiangdong <liuxiangdong5@huawei.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
alvaro.karsz@solid-run.com, Shannon Nelson <snelson@pensando.io>,
Laurent Vivier <lvivier@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
Gautam Dawar <gdawar@xilinx.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Cornelia Huck <cohuck@redhat.com>, Cindy Lu <lulu@redhat.com>,
Eli Cohen <eli@mellanox.com>, Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Parav Pandit <parav@mellanox.com>
Subject: [RFC v2 09/13] vdpa: add feature_log parameter to vhost_vdpa
Date: Thu, 12 Jan 2023 18:24:30 +0100 [thread overview]
Message-ID: <20230112172434.760850-10-eperezma@redhat.com> (raw)
In-Reply-To: <20230112172434.760850-1-eperezma@redhat.com>
This way the device's vhost_vdpa can make the choice about exposing or
not the _F_LOG feature.
At the moment it is always false.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
include/hw/virtio/vhost-vdpa.h | 1 +
hw/virtio/vhost-vdpa.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
index 7997f09a8d..7bcbcdb1dd 100644
--- a/include/hw/virtio/vhost-vdpa.h
+++ b/include/hw/virtio/vhost-vdpa.h
@@ -39,6 +39,7 @@ typedef struct vhost_vdpa {
MemoryListener listener;
struct vhost_vdpa_iova_range iova_range;
uint64_t acked_features;
+ bool feature_log;
bool shadow_vqs_enabled;
/* Vdpa must send shadow addresses as IOTLB key for data queues, not GPA */
bool shadow_data;
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index a61a6b2a74..40b7e8706a 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1273,7 +1273,7 @@ static int vhost_vdpa_get_features(struct vhost_dev *dev,
struct vhost_vdpa *v = dev->opaque;
int ret = vhost_vdpa_get_dev_features(dev, features);
- if (ret == 0 && v->shadow_vqs_enabled) {
+ if (ret == 0 && (v->shadow_vqs_enabled || v->feature_log)) {
/* Add SVQ logging capabilities */
*features |= BIT_ULL(VHOST_F_LOG_ALL);
}
--
2.31.1
next prev parent reply other threads:[~2023-01-12 17:43 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 17:24 [RFC v2 00/13] Dinamycally switch to vhost shadow virtqueues at vdpa net migration Eugenio Pérez
2023-01-12 17:24 ` [RFC v2 01/13] vdpa: fix VHOST_BACKEND_F_IOTLB_ASID flag check Eugenio Pérez
2023-01-13 3:12 ` Jason Wang
2023-01-13 6:42 ` Eugenio Perez Martin
2023-01-16 3:01 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 02/13] vdpa net: move iova tree creation from init to start Eugenio Pérez
2023-01-13 3:53 ` Jason Wang
2023-01-13 7:28 ` Eugenio Perez Martin
2023-01-16 3:05 ` Jason Wang
2023-01-16 9:14 ` Eugenio Perez Martin
2023-01-17 4:30 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 03/13] vdpa: copy cvq shadow_data from data vqs, not from x-svq Eugenio Pérez
2023-01-12 17:24 ` [RFC v2 04/13] vdpa: rewind at get_base, not set_base Eugenio Pérez
2023-01-13 4:09 ` Jason Wang
2023-01-13 7:40 ` Eugenio Perez Martin
2023-01-16 3:32 ` Jason Wang
2023-01-16 9:53 ` Eugenio Perez Martin
2023-01-17 4:38 ` Jason Wang
2023-01-17 6:57 ` Eugenio Perez Martin
2023-01-12 17:24 ` [RFC v2 05/13] vdpa net: add migration blocker if cannot migrate cvq Eugenio Pérez
2023-01-13 4:24 ` Jason Wang
2023-01-13 7:46 ` Eugenio Perez Martin
2023-01-16 3:34 ` Jason Wang
2023-01-16 5:23 ` Michael S. Tsirkin
2023-01-16 9:33 ` Eugenio Perez Martin
2023-01-17 5:42 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 06/13] vhost: delay set_vring_ready after DRIVER_OK Eugenio Pérez
2023-01-13 4:36 ` Jason Wang
2023-01-13 8:19 ` Eugenio Perez Martin
2023-01-13 9:51 ` Stefano Garzarella
2023-01-13 10:03 ` Eugenio Perez Martin
2023-01-13 10:37 ` Stefano Garzarella
2023-01-17 15:15 ` Maxime Coquelin
2023-01-16 6:36 ` Jason Wang
2023-01-16 16:16 ` Eugenio Perez Martin
2023-01-17 5:36 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 07/13] vdpa: " Eugenio Pérez
2023-01-12 17:24 ` [RFC v2 08/13] vdpa: Negotiate _F_SUSPEND feature Eugenio Pérez
2023-01-13 4:39 ` Jason Wang
2023-01-13 8:45 ` Eugenio Perez Martin
2023-01-16 6:48 ` Jason Wang
2023-01-16 16:17 ` Eugenio Perez Martin
2023-01-12 17:24 ` Eugenio Pérez [this message]
2023-01-12 17:24 ` [RFC v2 10/13] vdpa net: allow VHOST_F_LOG_ALL Eugenio Pérez
2023-01-13 4:42 ` Jason Wang
2023-01-12 17:24 ` [RFC v2 11/13] vdpa: add vdpa net migration state notifier Eugenio Pérez
2023-01-13 4:54 ` Jason Wang
2023-01-13 9:00 ` Eugenio Perez Martin
2023-01-16 6:51 ` Jason Wang
2023-01-16 15:21 ` Eugenio Perez Martin
2023-01-17 9:58 ` Dr. David Alan Gilbert
2023-01-17 10:23 ` Eugenio Perez Martin
2023-01-17 12:54 ` Dr. David Alan Gilbert
2023-02-02 1:52 ` Si-Wei Liu
2023-02-02 15:28 ` Eugenio Perez Martin
2023-02-04 2:03 ` Si-Wei Liu
2023-02-13 9:47 ` Eugenio Perez Martin
2023-02-13 22:36 ` Si-Wei Liu
2023-02-14 18:51 ` Eugenio Perez Martin
2023-02-12 14:31 ` Eli Cohen
2023-01-12 17:24 ` [RFC v2 12/13] vdpa: preemptive kick at enable Eugenio Pérez
2023-01-13 2:31 ` Jason Wang
2023-01-13 3:25 ` Zhu, Lingshan
2023-01-13 3:39 ` Jason Wang
2023-01-13 9:06 ` Eugenio Perez Martin
2023-01-16 7:02 ` Jason Wang
2023-02-02 16:55 ` Eugenio Perez Martin
2023-02-02 0:56 ` Si-Wei Liu
2023-02-02 16:53 ` Eugenio Perez Martin
2023-02-04 11:04 ` Si-Wei Liu
2023-02-05 10:00 ` Michael S. Tsirkin
2023-02-06 5:08 ` Si-Wei Liu
2023-01-12 17:24 ` [RFC v2 13/13] vdpa: Conditionally expose _F_LOG in vhost_net devices Eugenio Pérez
2023-02-02 1:00 ` [RFC v2 00/13] Dinamycally switch to vhost shadow virtqueues at vdpa net migration Si-Wei Liu
2023-02-02 11:27 ` Eugenio Perez Martin
2023-02-03 5:08 ` Si-Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112172434.760850-10-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=arei.gonglei@huawei.com \
--cc=cohuck@redhat.com \
--cc=eli@mellanox.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=snelson@pensando.io \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).