qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	mrezanin@redhat.com,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Cédric Le Goater" <clegoate@redhat.com>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	"Jason J . Herne" <jjherne@linux.ibm.com>,
	"Marc Hartmayer" <mhartmay@linux.ibm.com>,
	"Eric Farman" <farman@linux.ibm.com>,
	"Claudio Imbrenda" <imbrenda@linux.ibm.com>
Subject: [PATCH v2 0/4] pc-bios/s390-ccw: Fixes and improvements for start.S
Date: Tue, 27 Jun 2023 09:46:59 +0200	[thread overview]
Message-ID: <20230627074703.99608-1-thuth@redhat.com> (raw)

Main motivation of this series was a bug that showed up when compiling
with Clang 16 and binutils 2.40 (which has been reported in Fedora ELN, see
https://bugzilla.redhat.com/show_bug.cgi?id=2216662). This is fixed in
the fourth patch. I checked with "objdump" that the change is fine, indeed.

While working on this issue, I came accross some other issues which I
address in the first three patches:

- Indentation is a mixture between tabs and spaces in start.S (patch 1)
- We do not set up a stack frame for the main() function, which could
  cause memory corruption (patch 2)
- The stack is declared in multiple places, though it's only needed
  in start.S (patch 3)

v2:
- Use ".space" instead of ".lcomm" in the third patch to make sure
  that the alignment is really taken into consideration (thanks Richard)
- Alignment of 8 should be enough in the third patch (thank Christian)
- Added Reviewed-bys from v1

Thomas Huth (4):
  pc-bios/s390-ccw: Fix indentation in start.S
  pc-bios/s390-ccw: Provide space for initial stack frame in start.S
  pc-bios/s390-ccw: Move the stack array into start.S
  pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction

 pc-bios/s390-ccw/s390-ccw.h |   1 -
 pc-bios/s390-ccw/main.c     |   1 -
 pc-bios/s390-ccw/netmain.c  |   1 -
 pc-bios/s390-ccw/start.S    | 144 +++++++++++++++++++-----------------
 4 files changed, 76 insertions(+), 71 deletions(-)

-- 
2.39.3



             reply	other threads:[~2023-06-27  7:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27  7:46 Thomas Huth [this message]
2023-06-27  7:47 ` [PATCH v2 1/4] pc-bios/s390-ccw: Fix indentation in start.S Thomas Huth
2023-06-27  9:15   ` Philippe Mathieu-Daudé
2023-06-27  9:27   ` Claudio Imbrenda
2023-06-27 10:01   ` Eric Farman
2023-06-27  7:47 ` [PATCH v2 2/4] pc-bios/s390-ccw: Provide space for initial stack frame " Thomas Huth
2023-06-27  8:26   ` Marc Hartmayer
2023-06-27  9:14     ` Philippe Mathieu-Daudé
2023-06-27 10:02       ` Eric Farman
2023-06-27 11:55       ` Thomas Huth
2023-06-27  9:27   ` Claudio Imbrenda
2023-06-27  7:47 ` [PATCH v2 3/4] pc-bios/s390-ccw: Move the stack array into start.S Thomas Huth
2023-06-27  9:28   ` Claudio Imbrenda
2023-06-27 10:14   ` Eric Farman
2023-06-27 15:47   ` Thomas Huth
2023-06-27  7:47 ` [PATCH v2 4/4] pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction Thomas Huth
2023-06-27  9:29   ` Claudio Imbrenda
2023-06-27 10:54     ` Thomas Huth
2023-06-27 10:44   ` Eric Farman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627074703.99608-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=clegoate@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=mhartmay@linux.ibm.com \
    --cc=mrezanin@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).