From: James Bottomley <jejb@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: [PATCH v8 0/2] tpm: add mssim backend
Date: Wed, 4 Oct 2023 14:42:17 -0400 [thread overview]
Message-ID: <20231004184219.6594-1-jejb@linux.ibm.com> (raw)
From: James Bottomley <James.Bottomley@HansenPartnership.com>
The requested feedback was to convert the tpmdev handler to being json
based, which requires rethreading all the backends. The good news is
this reduced quite a bit of code (especially as I converted it to
error_fatal handling as well, which removes the return status
threading). The bad news is I can't test any of the conversions.
swtpm still isn't building on opensuse and, apparently, passthrough
doesn't like my native TPM because it doesn't allow cancellation.
v3 pulls out more unneeded code in the visitor conversion, makes
migration work on external state preservation of the simulator and
adds documentation
v4 puts back the wrapper options (but doesn't add any for mssim since
it post dates the necessity)
v5 rebases to the latest master branch and adjusts for removed use_FOO ptrs
v5 updates help to exit zero; does some checkpatch tidying
v7 merge review feedback and add acks.
v8 adds better error handling, more code tidies and adds command
socket disconnection/reconnection (instead of trying to keep the
socket open the whole time). This adds overhead, but makes
debugging guest kernel TPM issues much easier.
James
---
James Bottomley (2):
tpm: convert tpmdev options processing to new visitor format
tpm: add backend for mssim
MAINTAINERS | 6 +
backends/tpm/Kconfig | 5 +
backends/tpm/meson.build | 1 +
backends/tpm/tpm_emulator.c | 25 ++-
backends/tpm/tpm_mssim.c | 319 +++++++++++++++++++++++++++++++++
backends/tpm/tpm_mssim.h | 44 +++++
backends/tpm/tpm_passthrough.c | 23 +--
docs/specs/tpm.rst | 39 ++++
include/sysemu/tpm.h | 4 +-
include/sysemu/tpm_backend.h | 2 +-
qapi/tpm.json | 49 ++++-
softmmu/tpm-hmp-cmds.c | 9 +
softmmu/tpm.c | 91 ++++------
softmmu/vl.c | 19 +-
14 files changed, 528 insertions(+), 108 deletions(-)
create mode 100644 backends/tpm/tpm_mssim.c
create mode 100644 backends/tpm/tpm_mssim.h
--
2.35.3
next reply other threads:[~2023-10-04 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 18:42 James Bottomley [this message]
2023-10-04 18:42 ` [PATCH v8 1/2] tpm: convert tpmdev options processing to new visitor format James Bottomley
2023-10-04 18:42 ` [PATCH v8 2/2] tpm: add backend for mssim James Bottomley
2023-10-05 6:49 ` Philippe Mathieu-Daudé
2023-10-05 13:57 ` James Bottomley
2023-10-05 16:11 ` Philippe Mathieu-Daudé
2023-10-05 19:28 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004184219.6594-1-jejb@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).