qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 30/41] target/arm: Handle FEAT_NV2 changes to when SPSR_EL1.M reports EL2
Date: Thu, 11 Jan 2024 11:04:54 +0000	[thread overview]
Message-ID: <20240111110505.1563291-31-peter.maydell@linaro.org> (raw)
In-Reply-To: <20240111110505.1563291-1-peter.maydell@linaro.org>

With FEAT_NV2, the condition for when SPSR_EL1.M should report that
an exception was taken from EL2 changes.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Miguel Luis <miguel.luis@oracle.com>
---
 target/arm/helper.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 53bd6c85990..b9b3aaf4db7 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -11328,10 +11328,18 @@ static void arm_cpu_do_interrupt_aarch64(CPUState *cs)
         aarch64_save_sp(env, arm_current_el(env));
         env->elr_el[new_el] = env->pc;
 
-        if (cur_el == 1 && new_el == 1 &&
-            ((arm_hcr_el2_eff(env) & (HCR_NV | HCR_NV1)) == HCR_NV)) {
-            /* I_ZJRNN: report EL2 in the SPSR by setting M[3:2] to 0b10 */
-            old_mode = deposit32(old_mode, 2, 2, 2);
+        if (cur_el == 1 && new_el == 1) {
+            uint64_t hcr = arm_hcr_el2_eff(env);
+            if ((hcr & (HCR_NV | HCR_NV1 | HCR_NV2)) == HCR_NV ||
+                (hcr & (HCR_NV | HCR_NV2)) == (HCR_NV | HCR_NV2)) {
+                /*
+                 * FEAT_NV, FEAT_NV2 may need to report EL2 in the SPSR
+                 * by setting M[3:2] to 0b10.
+                 * If NV2 is disabled, change SPSR when NV,NV1 == 1,0 (I_ZJRNN)
+                 * If NV2 is enabled, change SPSR when NV is 1 (I_DBTLM)
+                 */
+                old_mode = deposit32(old_mode, 2, 2, 2);
+            }
         }
     } else {
         old_mode = cpsr_read_for_spsr_elx(env);
-- 
2.34.1



  parent reply	other threads:[~2024-01-11 11:07 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 11:04 [PULL 00/41] target-arm queue Peter Maydell
2024-01-11 11:04 ` [PULL 01/41] hw/arm: add cache controller for Freescale i.MX6 Peter Maydell
2024-01-11 11:04 ` [PULL 02/41] hw/arm: Add minimal support for the STM32L4x5 SoC Peter Maydell
2024-01-11 11:04 ` [PULL 03/41] hw/arm: Add minimal support for the B-L475E-IOT01A board Peter Maydell
2024-01-11 11:04 ` [PULL 04/41] hw/intc/armv7m_nvic: add "num-prio-bits" property Peter Maydell
2024-01-11 11:04 ` [PULL 05/41] hw/arm/armv7m: alias the NVIC " Peter Maydell
2024-01-11 11:04 ` [PULL 06/41] hw/arm/socs: configure priority bits for existing SOCs Peter Maydell
2024-01-11 11:04 ` [PULL 07/41] hw/arm: Add missing QOM parent for v7-M SoCs Peter Maydell
2024-01-11 11:04 ` [PULL 08/41] target/arm: Set CTR_EL0.{IDC,DIC} for the 'max' CPU Peter Maydell
2024-01-17 21:24   ` Fabiano Rosas
2024-01-18  9:44     ` Peter Maydell
2024-01-18 12:57       ` Fabiano Rosas
2024-01-18 13:00         ` Peter Maydell
2024-01-11 11:04 ` [PULL 09/41] hw/intc/arm_gicv3_cpuif: handle LPIs in in the list registers Peter Maydell
2024-01-11 11:04 ` [PULL 10/41] target/arm: Handle HCR_EL2 accesses for bits introduced with FEAT_NV Peter Maydell
2024-01-11 11:04 ` [PULL 11/41] target/arm: Implement HCR_EL2.AT handling Peter Maydell
2024-01-11 11:04 ` [PULL 12/41] target/arm: Enable trapping of ERET for FEAT_NV Peter Maydell
2024-01-11 11:04 ` [PULL 13/41] target/arm: Always honour HCR_EL2.TSC when HCR_EL2.NV is set Peter Maydell
2024-01-11 11:04 ` [PULL 14/41] target/arm: Allow use of upper 32 bits of TBFLAG_A64 Peter Maydell
2024-01-11 11:04 ` [PULL 15/41] target/arm: Record correct opcode fields in cpreg for E2H aliases Peter Maydell
2024-01-11 11:04 ` [PULL 16/41] target/arm: *_EL12 registers should UNDEF when HCR_EL2.E2H is 0 Peter Maydell
2024-01-11 11:04 ` [PULL 17/41] target/arm: Make EL2 cpreg accessfns safe for FEAT_NV EL1 accesses Peter Maydell
2024-01-11 11:04 ` [PULL 18/41] target/arm: Move FPU/SVE/SME access checks up above ARM_CP_SPECIAL_MASK check Peter Maydell
2024-01-11 11:04 ` [PULL 19/41] target/arm: Trap sysreg accesses for FEAT_NV Peter Maydell
2024-01-11 11:04 ` [PULL 20/41] target/arm: Make NV reads of CurrentEL return EL2 Peter Maydell
2024-01-11 11:04 ` [PULL 21/41] target/arm: Set SPSR_EL1.M correctly when nested virt is enabled Peter Maydell
2024-01-11 11:04 ` [PULL 22/41] target/arm: Trap registers when HCR_EL2.{NV, NV1} == {1, 1} Peter Maydell
2024-01-11 11:04 ` [PULL 23/41] target/arm: Always use arm_pan_enabled() when checking if PAN is enabled Peter Maydell
2024-01-11 11:04 ` [PULL 24/41] target/arm: Don't honour PSTATE.PAN when HCR_EL2.{NV, NV1} == {1, 1} Peter Maydell
2024-01-11 11:04 ` [PULL 25/41] target/arm: Treat LDTR* and STTR* as LDR/STR when NV, NV1 is 1, 1 Peter Maydell
2024-01-11 11:04 ` [PULL 26/41] target/arm: Handle FEAT_NV page table attribute changes Peter Maydell
2024-01-11 11:04 ` [PULL 27/41] target/arm: Add FEAT_NV to max, neoverse-n2, neoverse-v1 CPUs Peter Maydell
2024-01-11 11:04 ` [PULL 28/41] target/arm: Handle HCR_EL2 accesses for FEAT_NV2 bits Peter Maydell
2024-01-11 11:04 ` [PULL 29/41] target/arm: Implement VNCR_EL2 register Peter Maydell
2024-01-11 11:04 ` Peter Maydell [this message]
2024-01-11 11:04 ` [PULL 31/41] target/arm: Handle FEAT_NV2 redirection of SPSR_EL2, ELR_EL2, ESR_EL2, FAR_EL2 Peter Maydell
2024-01-11 11:04 ` [PULL 32/41] target/arm: Implement FEAT_NV2 redirection of sysregs to RAM Peter Maydell
2024-01-11 11:04 ` [PULL 33/41] target/arm: Report VNCR_EL2 based faults correctly Peter Maydell
2024-01-11 11:04 ` [PULL 34/41] target/arm: Mark up VNCR offsets (offsets 0x0..0xff) Peter Maydell
2024-01-11 11:04 ` [PULL 35/41] target/arm: Mark up VNCR offsets (offsets 0x100..0x160) Peter Maydell
2024-01-11 11:05 ` [PULL 36/41] target/arm: Mark up VNCR offsets (offsets 0x168..0x1f8) Peter Maydell
2024-01-11 11:05 ` [PULL 37/41] target/arm: Mark up VNCR offsets (offsets >= 0x200, except GIC) Peter Maydell
2024-01-11 11:05 ` [PULL 38/41] hw/intc/arm_gicv3_cpuif: Mark up VNCR offsets for GIC CPU registers Peter Maydell
2024-01-11 11:05 ` [PULL 39/41] target/arm: Report HCR_EL2.{NV,NV1,NV2} in cpu dumps Peter Maydell
2024-01-11 11:05 ` [PULL 40/41] target/arm: Enhance CPU_LOG_INT to show SPSR on AArch64 exception-entry Peter Maydell
2024-01-11 11:05 ` [PULL 41/41] target/arm: Add FEAT_NV2 to max, neoverse-n2, neoverse-v1 CPUs Peter Maydell
2024-01-11 15:16 ` [PULL 00/41] target-arm queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240111110505.1563291-31-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).