From: Hanna Czenczek <hreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Hanna Czenczek <hreitz@redhat.com>,
qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Fiona Ebner <f.ebner@proxmox.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Fam Zheng <fam@euphon.net>
Subject: [PATCH v2 0/3] virtio: Re-enable notifications after drain
Date: Fri, 2 Feb 2024 16:31:55 +0100 [thread overview]
Message-ID: <20240202153158.788922-1-hreitz@redhat.com> (raw)
v1:
https://lists.nongnu.org/archive/html/qemu-block/2024-01/msg00336.html
Hi,
This is basically the same series as v1: When using
aio_set_event_notifier_poll(), the io_poll_end() callback is only
invoked when polling ends, not when the notifier is being removed while
in a polling section. This can leave the virtqueue notifier disabled
during drained sections, which however is not a bad thing. We just need
to ensure they are re-enabled after the drain, and kick the virtqueue
once to pick up all the requests that came in during the drained
section.
Patch 1 is a technically unrelated fix, but addresses a problem that
became visible with patch 2 applied.
Patch 3 is a small (optional) clean-up patch.
v2:
- Changed the title of this series and patch 2 (was: "Keep notifications
disabled durin drain"): Keeping the notifier disabled was something
the initial RFC did, this version (v1 too) just ensures the notifier
is enabled after the drain, regardless of its state before.
- Use event_notifier_set() instead of virtio_queue_notify() in patch 2
- Added patch 3
Hanna Czenczek (3):
virtio-scsi: Attach event vq notifier with no_poll
virtio: Re-enable notifications after drain
virtio-blk: Use ioeventfd_attach in start_ioeventfd
include/block/aio.h | 7 ++++++-
hw/block/virtio-blk.c | 21 ++++++++++-----------
hw/scsi/virtio-scsi.c | 7 ++++++-
hw/virtio/virtio.c | 42 ++++++++++++++++++++++++++++++++++++++++++
4 files changed, 64 insertions(+), 13 deletions(-)
--
2.43.0
next reply other threads:[~2024-02-02 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 15:31 Hanna Czenczek [this message]
2024-02-02 15:31 ` [PATCH v2 1/3] virtio-scsi: Attach event vq notifier with no_poll Hanna Czenczek
2024-02-02 15:31 ` [PATCH v2 2/3] virtio: Re-enable notifications after drain Hanna Czenczek
2024-02-02 15:31 ` [PATCH v2 3/3] virtio-blk: Use ioeventfd_attach in start_ioeventfd Hanna Czenczek
2024-02-09 14:38 ` Michael Tokarev
2024-02-09 17:11 ` Hanna Czenczek
2024-02-10 8:37 ` Michael Tokarev
2024-02-06 18:39 ` [PATCH v2 0/3] virtio: Re-enable notifications after drain Stefan Hajnoczi
2024-02-07 20:52 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202153158.788922-1-hreitz@redhat.com \
--to=hreitz@redhat.com \
--cc=f.ebner@proxmox.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).