From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E36AEC33CB1 for ; Thu, 16 Jan 2020 12:56:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE02D2073A for ; Thu, 16 Jan 2020 12:56:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="J4Au+H7F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE02D2073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is4h6-0005LJ-UX for qemu-devel@archiver.kernel.org; Thu, 16 Jan 2020 07:56:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38039) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1is4gT-0004uG-HY for qemu-devel@nongnu.org; Thu, 16 Jan 2020 07:55:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1is4gP-0000ZI-L7 for qemu-devel@nongnu.org; Thu, 16 Jan 2020 07:55:37 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:55401 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1is4gP-0000YJ-GO for qemu-devel@nongnu.org; Thu, 16 Jan 2020 07:55:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579179333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=rxjueyAPdWj7uhqbDrjfDH02y9EMRnTDyLQFGYRe1Xo=; b=J4Au+H7FDjnzMnaoSgp6R5MbJtxwQIDwaEIUPqobObK8CGha+kbTCmfhbe+Q3SdCf5Sxla m61X1Grit3oWPioWwxj2cGQQQBAS2AZL0HpPmjis30eYKbFDtWC2JqhaewW4zCYHSOYsC7 qgCQV5ZAM8r5xTFsr66enOMnBFirHZw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-88-GFIEism5N_i7G0gHB5Bjpw-1; Thu, 16 Jan 2020 07:55:29 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1CC210054E3; Thu, 16 Jan 2020 12:55:28 +0000 (UTC) Received: from thuth.remote.csb (ovpn-204-105.brq.redhat.com [10.40.204.105]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9572C60C63; Thu, 16 Jan 2020 12:55:24 +0000 (UTC) Subject: Re: [PATCH] target/s390x/kvm: Enable adapter interruption suppression again To: Cornelia Huck , Christian Borntraeger References: <20200116122026.5804-1-thuth@redhat.com> <20200116135038.2c8cf3c6.cohuck@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <20b2df78-8d5c-3508-cc80-06cf127ca635@redhat.com> Date: Thu, 16 Jan 2020 13:55:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200116135038.2c8cf3c6.cohuck@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: GFIEism5N_i7G0gHB5Bjpw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Halil Pasic , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, David Hildenbrand Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 16/01/2020 13.50, Cornelia Huck wrote: > On Thu, 16 Jan 2020 13:20:26 +0100 > Thomas Huth wrote: > >> The AIS feature has been disabled late in the v2.10 development >> cycle since there were some issues with migration (see commit >> 3f2d07b3b01ea61126b - "s390x/ais: for 2.10 stable: disable ais >> facility"). We originally wanted to enable it again for newer >> machine types, but apparently we forgot to do this so far. Let's >> do it for the new s390-ccw-virtio-5.0 machine now. >> >> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1756946 >> Signed-off-by: Thomas Huth >> --- >> hw/s390x/s390-virtio-ccw.c | 4 ++++ >> include/hw/s390x/s390-virtio-ccw.h | 4 ++++ >> target/s390x/kvm.c | 11 ++++++++--- >> 3 files changed, 16 insertions(+), 3 deletions(-) >> > >> @@ -365,10 +367,13 @@ int kvm_arch_init(MachineState *ms, KVMState *s) >> /* >> * The migration interface for ais was introduced with kernel 4.13 >> * but the capability itself had been active since 4.12. As migration >> - * support is considered necessary let's disable ais in the 2.10 >> - * machine. >> + * support is considered necessary we only enable this for newer > > s/necessary we only enable this/necessary, we only try to enable this/ > >> + * machine types and if KVM_CAP_S390_AIS_MIGRATION is available. > > maybe s/and if/if/ Sure ... could you fix it up when picking up the patch (in case I don't have to respin), or do you want me to send a v2? >> */ >> - /* kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0); */ >> + if (smc->kvm_ais_allowed && >> + kvm_check_extension(s, KVM_CAP_S390_AIS_MIGRATION)) { >> + kvm_vm_enable_cap(s, KVM_CAP_S390_AIS, 0); >> + } >> >> kvm_set_max_memslot_size(KVM_SLOT_MAX_BYTES); >> return 0; > > Looks good. > > Remind me again: ais only made a difference for pci devices, right? Is > it enough to give this a quick whirl with virtio-pci devices? I don't remember the details, Christian, could you please answer this question? Thomas