From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB02CC433DB for ; Fri, 15 Jan 2021 15:26:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 000E822473 for ; Fri, 15 Jan 2021 15:26:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 000E822473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0QzW-0008WO-2t for qemu-devel@archiver.kernel.org; Fri, 15 Jan 2021 10:26:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0Qxw-0007pP-8d; Fri, 15 Jan 2021 10:24:47 -0500 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]:38594) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0Qxu-0006cJ-Nl; Fri, 15 Jan 2021 10:24:44 -0500 Received: by mail-ej1-x632.google.com with SMTP id 6so13832475ejz.5; Fri, 15 Jan 2021 07:24:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LLfoZnEhqqH7tIuWTVkeS30vFx9Vz628e63bkWRf8xg=; b=llbJ2qKbIK7yx4NVf7/owD+CTGOrA1BHQYdKlXcZZIoPL3Do4Pn5Q+H+O4Gd7+GbzN pFDzs0D2RXrXPmoUQz2MRXIg4HZaeI1HF6HX39yZn54VmWbVP68R5Zc4wKjNRMavu1pd o7m5sQZ53va0zEJQcjGT184Tp8RB920kKYOWQ9h12uoPEOBhtnvRJ7LKmD06UUAsOpDf VaWtRyXRzO1D8GQjcs4D88Xnx76pFUtI/gTfFRup0E2TvlDuYFJFcozGSC0njd3d6i6I 5JiUWnc7FQDCBRXmpnfrRYyObPqaz6hQhbBekF3QJ/5QeYq0WFtnYqyxjAbRmvUlotSc +l+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LLfoZnEhqqH7tIuWTVkeS30vFx9Vz628e63bkWRf8xg=; b=omyVknqv6OQ0HJY7C0IudS0z0C9dvA491BDY5rWCimZ2t9ByF8K0zXsQEkF2zw/rNR XtF3pD/p5ZwTQcNqeny+qYnafX78S80JcRpw+BeDbNM1FI8GkMwjBFc499muE+RCkYeA IYZjzV4+rRHBPqgFYBHYwO+6nafLNuyK2wc6WOeq/0uXXar5QcpJL74FSWrMQtOX90te 5V7ZwEurvCFH7xbSqZxhCLS+PKBE6zEYTKVyGorc7G1CZ1oIXVpw4H3FcvKFtlRXADsk l3JqJYlvsUPEbCl1Lt2Fd3gpZ6CSL84k436CSdaxQEOUsoJwPWPxRKbnGijjPdC1q3iG 9n2g== X-Gm-Message-State: AOAM533SSisR/G+It8xG9eDbf8IpAaex6yLGtRcrywnGDlcjtu1H+wGv uBYpKIX79olzKbSLNH33X/s= X-Google-Smtp-Source: ABdhPJzFt+i2sVirl5qrlas0/fd6ESfvmlFxylISFkr+yDTfxdFesZ1yE/GFholNATUZapIWQdorZQ== X-Received: by 2002:a17:906:ce51:: with SMTP id se17mr9059210ejb.314.1610724280497; Fri, 15 Jan 2021 07:24:40 -0800 (PST) Received: from [192.168.1.36] (13.red-83-57-169.dynamicip.rima-tde.net. [83.57.169.13]) by smtp.gmail.com with ESMTPSA id q20sm3701495eju.1.2021.01.15.07.24.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jan 2021 07:24:39 -0800 (PST) Subject: Re: [RFC PATCH v6 04/11] hw/ssi: imx_spi: Reduce 'change_mask' variable scope To: quintela@redhat.com References: <20210112183529.2011863-1-f4bug@amsat.org> <20210112183529.2011863-5-f4bug@amsat.org> <87im81gdig.fsf@secure.mitica> <875z41gd8c.fsf@secure.mitica> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <21102f76-d7b1-0b98-ad66-d8d76348aaef@amsat.org> Date: Fri, 15 Jan 2021 16:24:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <875z41gd8c.fsf@secure.mitica> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Alistair Francis , Bin Meng , qemu-devel@nongnu.org, Jean-Christophe Dubois , qemu-arm@nongnu.org, Peter Chubb , Bin Meng Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/13/21 2:47 PM, Juan Quintela wrote: > Juan Quintela wrote: >> Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >> >> I think this one is wrong. > > Wrong is a strong word. I mean that it changes behaviour and the commit > message don't talk about changing behaviour. Indeed. Well I'll simply drop this patch as it is not essential. Thanks for reviewing the series! Phil.