From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Bihong Yu <yubihong@huawei.com>,
Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Subject: Re: [PULL 00/16] migration queue
Date: Sun, 01 Nov 2020 11:17:50 +0100 [thread overview]
Message-ID: <2112217.elGldtz0XA@silver> (raw)
In-Reply-To: <1908851.GJEdv41Ba9@silver>
On Samstag, 31. Oktober 2020 20:10:49 CET Christian Schoenebeck wrote:
> On Samstag, 31. Oktober 2020 18:46:11 CET Peter Xu wrote:
> > On Sat, Oct 31, 2020 at 05:26:28PM +0000, Peter Maydell wrote:
> > > On Sat, 31 Oct 2020 at 16:12, Christian Schoenebeck
> > >
> > > <qemu_oss@crudebyte.com> wrote:
> > > > On Montag, 26. Oktober 2020 17:19:36 CET Dr. David Alan Gilbert (git)
>
> wrote:
> > > > > ----------------------------------------------------------------
> > > > > migration pull: 2020-10-26
> > > > >
> > > > > Another go at Peter's postcopy fixes
> > > > >
> > > > > Cleanups from Bihong Yu and Peter Maydell.
> > > > >
> > > > > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > > >
> > > > May it be possible that this PR introduced a lockup of the qtests that
> > > > I
> > > > am
> > > > encountering in this week's upstream revisions?
> > >
> > > If you try the patches Peter Xu attached to this thread
> > > does the lockup go away ?
> > >
> > > https://lore.kernel.org/qemu-devel/20201030135350.GA588069@xz-x1/
> > >
> > > (I'm also seeing intermittent hangs, for some reason almost always
> > > on s390x host.)
> >
> > It would be good to know exactly which test hanged. If it's
> > migration-test
> > then it's very possible.
>
> It's run-test-144 that does not return; according to Makefile.mtest that's
> migration-test, so chances are high that it's indeed introduced by this PR.
>
> > The race above patch(es) tried to fix should logically be reproducable on
> > all archs, not s390x only.
> >
> > Thanks,
>
> Yes, it's i386 here that locks up.
>
> I'm running the loop with your patches now, so far so good, let's see if
> it's still alive tomorrow.
>
> Best regards,
> Christian Schoenebeck
Looks good! 16h later and the loop is still running here; it also made the
lockup to disappear on Travis-CI. So Peter Xu's two patches fix the lockup
problem for me.
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2020-11-01 10:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 16:19 [PULL 00/16] migration queue Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 01/16] migration: Drop unused VMSTATE_FLOAT64 support Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 02/16] migration: Do not use C99 // comments Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 03/16] migration: Don't use '#' flag of printf format Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 04/16] migration: Add spaces around operator Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 05/16] migration: Open brace '{' following struct go on the same line Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 06/16] migration: Add braces {} for if statement Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 07/16] migration: Do not initialise statics and globals to 0 or NULL Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 08/16] migration: Open brace '{' following function declarations go on the next line Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 09/16] migration: Delete redundant spaces Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 10/16] migration: using trace_ to replace DPRINTF Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 11/16] migration: Pass incoming state into qemu_ufd_copy_ioctl() Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 12/16] migration: Introduce migrate_send_rp_message_req_pages() Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 13/16] migration: Maintain postcopy faulted addresses Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 14/16] migration: Sync requested pages after postcopy recovery Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 15/16] migration/postcopy: Release fd before going into 'postcopy-pause' Dr. David Alan Gilbert (git)
2020-10-26 16:19 ` [PULL 16/16] migration-test: Only hide error if !QTEST_LOG Dr. David Alan Gilbert (git)
2020-10-26 16:39 ` [PULL 00/16] migration queue no-reply
2020-10-26 16:52 ` Dr. David Alan Gilbert
2020-10-27 11:28 ` Peter Maydell
2020-10-31 16:12 ` Christian Schoenebeck
2020-10-31 17:26 ` Peter Maydell
2020-10-31 17:46 ` Peter Xu
2020-10-31 19:10 ` Christian Schoenebeck
2020-11-01 10:17 ` Christian Schoenebeck [this message]
2022-05-09 15:02 Dr. David Alan Gilbert (git)
2022-05-10 8:33 Dr. David Alan Gilbert (git)
2022-05-10 9:58 ` Dr. David Alan Gilbert
2022-05-10 10:19 ` Daniel P. Berrangé
2022-05-10 10:43 ` Dr. David Alan Gilbert
2022-05-11 3:40 ` Leonardo Bras Soares Passos
2022-05-11 8:55 ` Dr. David Alan Gilbert
2022-05-13 6:28 ` Leonardo Bras Soares Passos
2022-05-16 8:18 ` Dr. David Alan Gilbert
2022-05-16 8:51 ` Stefan Hajnoczi
2022-05-16 9:40 ` Daniel P. Berrangé
2022-05-16 10:09 ` Daniel P. Berrangé
2022-05-16 15:30 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2112217.elGldtz0XA@silver \
--to=qemu_oss@crudebyte.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yubihong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).