From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] cutils: fix memory leak in get_relocated_path()
Date: Tue, 13 Apr 2021 12:59:36 +0200 [thread overview]
Message-ID: <22828e2d-2c8e-c753-31e5-7588f9064b10@redhat.com> (raw)
In-Reply-To: <20210412170255.231406-1-sgarzare@redhat.com>
Is this fix aiming at 6.0 release?
On 4/12/21 7:02 PM, Stefano Garzarella wrote:
> get_relocated_path() allocates a GString object and returns the
> character data (C string) to the caller without freeing the memory
> allocated for that object as reported by valgrind:
>
> 24 bytes in 1 blocks are definitely lost in loss record 2,805 of 6,532
> at 0x4839809: malloc (vg_replace_malloc.c:307)
> by 0x55AABB8: g_malloc (in /usr/lib64/libglib-2.0.so.0.6600.8)
> by 0x55C2481: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.6600.8)
> by 0x55C4827: g_string_sized_new (in /usr/lib64/libglib-2.0.so.0.6600.8)
> by 0x55C4CEA: g_string_new (in /usr/lib64/libglib-2.0.so.0.6600.8)
> by 0x906314: get_relocated_path (cutils.c:1036)
> by 0x6E1F77: qemu_read_default_config_file (vl.c:2122)
> by 0x6E1F77: qemu_init (vl.c:2687)
> by 0x3E3AF8: main (main.c:49)
>
> Let's use g_string_free(gstring, false) to free only the GString object
> and transfer the ownership of the character data to the caller.
>
> Fixes: f4f5ed2cbd ("cutils: introduce get_relocated_path")
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> util/cutils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/cutils.c b/util/cutils.c
> index ee908486da..c9b91e7535 100644
> --- a/util/cutils.c
> +++ b/util/cutils.c
> @@ -1055,5 +1055,5 @@ char *get_relocated_path(const char *dir)
> assert(G_IS_DIR_SEPARATOR(dir[-1]));
> g_string_append(result, dir - 1);
> }
> - return result->str;
> + return g_string_free(result, false);
> }
>
next prev parent reply other threads:[~2021-04-13 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 17:02 [PATCH] cutils: fix memory leak in get_relocated_path() Stefano Garzarella
2021-04-13 10:59 ` Philippe Mathieu-Daudé [this message]
2021-04-13 11:47 ` Stefano Garzarella
2021-04-13 16:03 ` Philippe Mathieu-Daudé
2021-04-14 7:32 ` Marc-André Lureau
2021-05-10 15:57 ` Stefano Garzarella
2021-05-11 5:38 ` Markus Armbruster
2021-05-13 16:08 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22828e2d-2c8e-c753-31e5-7588f9064b10@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).