From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C555EC433ED for ; Wed, 14 Apr 2021 08:29:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BFA1613C0 for ; Wed, 14 Apr 2021 08:29:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BFA1613C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWauC-0003OA-0M for qemu-devel@archiver.kernel.org; Wed, 14 Apr 2021 04:29:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWat8-0002Zo-5r for qemu-devel@nongnu.org; Wed, 14 Apr 2021 04:28:42 -0400 Received: from mx2.suse.de ([195.135.220.15]:49574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWat6-00022K-Hn for qemu-devel@nongnu.org; Wed, 14 Apr 2021 04:28:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B13D9AD8D; Wed, 14 Apr 2021 08:28:38 +0000 (UTC) Subject: Re: [RFC v12 03/65] arm: tcg: only build under CONFIG_TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Peter Maydell , Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini References: <20210326193701.5981-1-cfontana@suse.de> <20210326193701.5981-4-cfontana@suse.de> From: Claudio Fontana Message-ID: <23006513-c0c9-bca1-d1c7-5d5fd6f679f6@suse.de> Date: Wed, 14 Apr 2021 10:28:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Roman Bolshakov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/13/21 10:49 PM, Philippe Mathieu-Daudé wrote: > On 3/26/21 8:35 PM, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana >> Reviewed-by: Richard Henderson >> Reviewed-by: Alex Bennée >> --- >> target/arm/tcg/meson.build | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build >> index 0bd4e9d954..3b4146d079 100644 >> --- a/target/arm/tcg/meson.build >> +++ b/target/arm/tcg/meson.build >> @@ -12,9 +12,9 @@ gen = [ >> decodetree.process('t16.decode', extra_args: ['-w', '16', '--static-decode=disas_t16']), >> ] >> >> -arm_ss.add(gen) >> +arm_ss.add(when: 'CONFIG_TCG', if_true: gen) >> >> -arm_ss.add(files( >> +arm_ss.add(when: 'CONFIG_TCG', if_true: files( >> 'translate.c', >> 'helper.c', >> 'iwmmxt_helper.c', >> @@ -28,7 +28,7 @@ arm_ss.add(files( >> 'debug_helper.c', >> )) >> >> -arm_ss.add(when: 'TARGET_AARCH64', if_true: files( >> +arm_ss.add(when: ['TARGET_AARCH64','CONFIG_TCG'], if_true: files( >> 'translate-a64.c', >> 'translate-sve.c', >> 'helper-a64.c', >> > > Isn't it clearer to use in target/arm/meson.build: > > if 'CONFIG_TCG' in config_all > subdir('tcg') > endif > > ? This was my initial idea also, but now it is not possible anymore, since we now put some tcg stubs in tcg/. We could instead put them in a dedicated stubs/ directory though. The reason is basically that Paolo suggested to recurse unconditionally, I just considered this meson-related statement as an oracle. Ciao, Claudio > > Similarly in the next patch for target/arm/tcg/meson.build: > > if have_user > subdir('user') > endif > if have_system > subdir('sysemu') > endif >