From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Thomas Huth <thuth@redhat.com>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
Greg Kurz <groug@kaod.org>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-ppc@nongnu.org, "Willian Rampazzo" <wrampazz@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH 1/3] tests/acceptance: Move the pseries test to a separate file
Date: Thu, 4 Feb 2021 09:52:50 +0100 [thread overview]
Message-ID: <23ca4afc-97a9-7438-0182-93cd49271d4e@amsat.org> (raw)
In-Reply-To: <67dde2d9-1d87-35fa-9233-9264b0731e28@redhat.com>
Hi Thomas,
On 1/13/21 6:30 AM, Thomas Huth wrote:
> On 12/01/2021 19.50, Wainer dos Santos Moschetta wrote:
>> Hi,
>>
>> On 1/12/21 1:40 PM, Thomas Huth wrote:
>>> Let's gather the POWER-related tests in a separate file.
>>
>>
>> Did you consider having others ppc/ppc64 boot tests together too?
>>
>> Some candidates:
>>
>> tests/acceptance/boot_linux.py:BootLinuxPPC64.test_pseries_tcg
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_ppc64_e500
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_ppc_g3beige
>> tests/acceptance/boot_linux_console.py:BootLinuxConsole.test_ppc_mac99
>
> The e500, g3beige and mac99 tests are depending on the
> do_test_advcal_2018() function in that file, so I think they should
> rather stay there.
>
>> tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_factory_firmware_and_netbsd
>> tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_192m
>> tests/acceptance/ppc_prep_40p.py:IbmPrep40pMachine.test_openbios_and_netbsd
>>
>
> That's a good point, I did not notice that file when writing my patches.
> Philippe, since you've created this ppc_prep_40p.py file, what do you
> think, should it be merged with the other ppc tests, or shall we rather
> keep this separate?
The choice was deliberate: the PReP machine has a different set of
maintainers. If possible when we have a particular section in
MAINTAINERS I'd like to use it as separation, to let the maintainers
track changes in tests.
In this example, Hervé is interested to look for PReP related files,
but doesn't have bandwidth to look at all PPC patches.
If this doesn't scale, I suggested (was it on the list or directly
to Willian?) to add a Python script to map Avocado test tags to
MAINTAINERS entry, so 1/ maintainers could run all tests linked to
their subsystem by naming the subsystem, and 2/ when a test fails
we know which maintainer to contact.
Regards,
Phil.
next prev parent reply other threads:[~2021-02-04 8:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 16:40 [PATCH 0/3] Acceptance tests for mpc8544ds & virtex-ml507 ppc machines Thomas Huth
2021-01-12 16:40 ` [PATCH 1/3] tests/acceptance: Move the pseries test to a separate file Thomas Huth
2021-01-12 18:50 ` Wainer dos Santos Moschetta
2021-01-13 5:30 ` Thomas Huth
2021-02-04 8:52 ` Philippe Mathieu-Daudé [this message]
2021-02-04 12:59 ` Thomas Huth
2021-02-08 19:57 ` Willian Rampazzo
2021-01-12 20:36 ` Philippe Mathieu-Daudé
2021-01-13 1:14 ` David Gibson
2021-01-14 20:17 ` Willian Rampazzo
2021-01-12 16:40 ` [PATCH 2/3] tests/acceptance: Test the mpc8544ds machine Thomas Huth
2021-01-12 18:51 ` Wainer dos Santos Moschetta
2021-01-13 1:14 ` David Gibson
2021-01-15 17:19 ` Willian Rampazzo
2021-01-12 16:40 ` [PATCH 3/3] tests/acceptance: Add a test for the virtex-ml507 ppc machine Thomas Huth
2021-01-12 18:51 ` Wainer dos Santos Moschetta
2021-01-13 1:15 ` David Gibson
2021-01-15 17:20 ` Willian Rampazzo
2021-02-04 14:08 ` [PATCH 0/3] Acceptance tests for mpc8544ds & virtex-ml507 ppc machines Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23ca4afc-97a9-7438-0182-93cd49271d4e@amsat.org \
--to=f4bug@amsat.org \
--cc=crosa@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).