From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C5BC433DF for ; Tue, 19 May 2020 21:49:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA04F206BE for ; Tue, 19 May 2020 21:49:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Lw21wVNF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA04F206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbA73-0001Sq-Vf for qemu-devel@archiver.kernel.org; Tue, 19 May 2020 17:49:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jb9zd-0007pj-UF for qemu-devel@nongnu.org; Tue, 19 May 2020 17:41:46 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:41454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jb9zc-0000Hc-3w for qemu-devel@nongnu.org; Tue, 19 May 2020 17:41:45 -0400 Received: by mail-pf1-x443.google.com with SMTP id 23so509398pfy.8 for ; Tue, 19 May 2020 14:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CMye0gRnqmKea87uFYvrR2qGt7AWfI8R4JkHmzP32YI=; b=Lw21wVNFk/ef9zTd2wkJzOON9dfOfJGBjhEXeK4P387RP2jLEaJkdajlgoay5EcFQD 2Ff2Eb/pS/1Nq7nZQPtZLQJMT2GRX23Bx2o9sfspZJhfnn4MuPgGtK7lCG6mpsScj+CW eCM279MJYS2tqr8o64rYJaoQtRDzDUPa3RSu+iheZYbGYaFYSy2W+Qx0uwpdP/L72mdT 0ET2H/xsS9zS8n439yY0WnyTW+GiqF4qR0JzQg/1QzIRUVhnnWwPqirL4CM+Foj+C/Cn dWWcgLcUY3TA/53V3g0UCvduuMCVJQmd18ZFVUCjaExHSP4bWOzUD/rLah8CJENbZ5N1 liOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CMye0gRnqmKea87uFYvrR2qGt7AWfI8R4JkHmzP32YI=; b=QCf8ELSuXRuIKIOMjWCb6zh7pwyfWdveLogHo5Gmeyeeps/+HEV0QaWP9gFwTEAM0f D5QvI5t4h2MtWEUYNH8EXwK7DFlvvDl7S77ZSqzW4wdF+SPEzvH9JedRT49rhTnkqORS 3PNs1IKPMt4RLpQGgQfyINQraiCYQrtFeNfY8YdPKov7eyqvPDfYip9Um+MR/7NAKzCK H0AIIHXHq7LswZmISuKLUzWdGNGui0x6ieqmyJLfIf0tcq6jUWgnlxbwh3MXy123e11k zGYMGyMmbZaHN6Kjwa7jP8LgmPgSuYsyxeJOhmQxL2BfejNbihAc6xjf66aMuomYTK6H DP+w== X-Gm-Message-State: AOAM532KN2d8hwWm+vfqG8KhdPi+K6PyJM6gzO8viW3ftpv/eQJnl+gy kiYx1qCU2vGYeuolqe4Sx1M3fA== X-Google-Smtp-Source: ABdhPJwoC6noJKTG77fPfU2eCRRbQs2oAlFqLDHodQayiKG7+kIM2EtKvh92YwHJApOXyau7gQq42A== X-Received: by 2002:a63:2347:: with SMTP id u7mr1071376pgm.183.1589924500699; Tue, 19 May 2020 14:41:40 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id y5sm356466pff.150.2020.05.19.14.41.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 14:41:39 -0700 (PDT) Subject: Re: [PATCH v2 04/10] accel/tcg: Add stub for probe_access() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200515170804.5707-1-philmd@redhat.com> <20200515170804.5707-5-philmd@redhat.com> From: Richard Henderson Message-ID: <23e13589-1d57-8fc2-885d-b2fa34589d6b@linaro.org> Date: Tue, 19 May 2020 14:41:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200515170804.5707-5-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sagar Karandikar , David Hildenbrand , Laurent Vivier , Max Filippov , Alistair Francis , Marek Vasut , Aleksandar Markovic , "Emilio G . Cota" , Aleksandar Rikalo , Thomas Huth , qemu-arm@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , Richard Henderson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Michael Walle , Palmer Dabbelt , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/15/20 10:07 AM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > The TCG helpers where added in b92e5a22ec3 in softmmu_template.h. > probe_write() was added in there in 3b4afc9e75a to be moved out > to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored > as probe_access() in c25c283df0f. > Since it is a TCG specific helper, add a stub to avoid failures > when building without TCG, such: > > target/arm/helper.o: In function `probe_read': > include/exec/exec-all.h:362: undefined reference to `probe_access' > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Richard Henderson > Cc: Emilio G. Cota > Cc: Alex Bennée > Cc: David Hildenbrand > --- > accel/stubs/tcg-stub.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Richard Henderson r~