From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Artyom Tarasenko <atar4qemu@gmail.com>
Subject: Re: [PATCH-for-6.1 0/3] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs
Date: Sun, 2 May 2021 12:20:06 +0100 [thread overview]
Message-ID: <2531855e-f24e-cd38-7e67-edeae26d0dc5@ilande.co.uk> (raw)
In-Reply-To: <20210407175305.1771069-1-f4bug@amsat.org>
On 07/04/2021 18:53, Philippe Mathieu-Daudé wrote:
> Hi Mark,
>
> This series QOM'ify a bit more the sun4m machines.
> I need it for a further memory maxsize check.
> It is mostly code movement (and the diff-stat is good).
>
> Philippe Mathieu-Daudé (3):
> hw/sparc/sun4m: Introduce TYPE_SUN4M_MACHINE and Sun4mMachineClass
> hw/sparc/sun4m: Factor out sun4m_machine_class_common_init()
> hw/sparc/sun4m: Make sun4m_hwdefs a Sun4mMachineClass field
>
> hw/sparc/sun4m.c | 178 ++++++++++++++++++-----------------------------
> 1 file changed, 69 insertions(+), 109 deletions(-)
Hi Phil,
Possibly it might be worth having an abstract TYPE_SUN4M_MACHINE and then for each
sun4m machine to have that as a parent type? This would allow you to move
sun4m_machine_class_common_init() directly into the abstract
sun4m_machine_class_init() rather than having to call a function from within each
individual class init function.
No objection to the cleanup though :)
ATB,
Mark.
next prev parent reply other threads:[~2021-05-02 11:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 17:53 [PATCH-for-6.1 0/3] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs Philippe Mathieu-Daudé
2021-04-07 17:53 ` [PATCH-for-6.1 1/3] hw/sparc/sun4m: Introduce TYPE_SUN4M_MACHINE and Sun4mMachineClass Philippe Mathieu-Daudé
2021-04-07 17:53 ` [PATCH-for-6.1 2/3] hw/sparc/sun4m: Factor out sun4m_machine_class_common_init() Philippe Mathieu-Daudé
2021-04-07 17:53 ` [PATCH-for-6.1 3/3] hw/sparc/sun4m: Make sun4m_hwdefs a Sun4mMachineClass field Philippe Mathieu-Daudé
2021-05-02 11:20 ` Mark Cave-Ayland [this message]
2021-05-02 17:40 ` [PATCH-for-6.1 0/3] hw/sparc/sun4m: Introduce Sun4mMachineClass to access sun4m_hwdefs Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2531855e-f24e-cd38-7e67-edeae26d0dc5@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=atar4qemu@gmail.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).