On 24.06.19 20:35, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190624173935.25747-1-mreitz@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 20190624173935.25747-1-mreitz@redhat.com > Type: series > Subject: [Qemu-devel] [PATCH v4 00/14] block: Try to create well-typed json:{} filenames > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Switched to a new branch 'test' > ddd669a block: Make use of QAPI defaults > 3bcf922 iotests: qcow2's encrypt.format is now optional > 155c1db iotests: Test internal option typing > 364eac1 block: Try to create well typed json:{} filenames > 11726d2 qapi: Formalize qcow encryption probing > 567644f qapi: Formalize qcow2 encryption probing > 4eb3ca4 tests: Add QAPI optional discriminator tests > f3d9f53 tests: Test QAPI default values for struct members > 2862824 test-qapi: Print struct members' default values > ff7a7c5 qapi: Document default values for struct members > faef37f qapi: Allow optional discriminators > 64ae73c qapi: Introduce default values for struct members > f485950 qapi: Move to_c_string() to common.py > 8711bb4 qapi: Parse numeric values > > === OUTPUT BEGIN === > 1/14 Checking commit 8711bb4c30f3 (qapi: Parse numeric values) > 2/14 Checking commit f485950c4595 (qapi: Move to_c_string() to common.py) > 3/14 Checking commit 64ae73cfedd6 (qapi: Introduce default values for struct members) > 4/14 Checking commit faef37f6cd45 (qapi: Allow optional discriminators) > 5/14 Checking commit ff7a7c5b6024 (qapi: Document default values for struct members) > 6/14 Checking commit 28628249dcf1 (test-qapi: Print struct members' default values) > 7/14 Checking commit f3d9f5343a99 (tests: Test QAPI default values for struct members) > ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8 > #106: FILE: tests/qapi-schema/qapi-schema-test.out:420: > + member str: str optional=True default=foo \鹿""' > ^ Already noted in patch 7. Max