From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Denis Lunev" <den@virtuozzo.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"libvir-list@redhat.com" <libvir-list@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: Deprecating stuff for 4.2
Date: Fri, 8 Nov 2019 09:36:04 +0000 [thread overview]
Message-ID: <26371ed9-79ce-4d2a-e052-dca1310062b2@virtuozzo.com> (raw)
In-Reply-To: <87eeyirht2.fsf_-_@dusky.pond.sub.org>
08.11.2019 9:41, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
>
>> 07.11.2019 21:52, Philippe Mathieu-Daudé wrote:
> [...]
>>> Pre-release period, time to deprecate some stuffs :)
>>>
>>> How should we proceed? Do you have something in mind?
>>>
>>> There are older threads about this. Should we start a new thread? Gather the different ideas on the Wiki?
>>>
>>> (Obviously you are not the one responsible of this topic, you just happen to be the last one worried about it on the list).
>>>
>>> Regards,
>>>
>>> Phil.
>
> 4.2.0-rc0 has been tagged, i.e. we're in hard freeze already. Only bug
> fixes are accepted during hard freeze. We've occasionally bent this
> rule after -rc0 for borderline cases, e.g. to tweak a new external
> interface before the release calcifies it. Making a case for bending
> the rules becomes harder with each -rc.
>
> Ideally, we'd double-check new interfaces for gaffes before a release,
> and whether old interfaces that have been replaced now should be
> deprecated. There's rarely time for that, and pretty much never for
> releases right after KVM Forum.
>
> So no, I don't have anything in mind for 4.2.
>
> We intend to tag -rc1 next Tuesday. To make that deadline, we'd need
> patches, not just ideas.
>
>> Hi!
>>
>> I wanted to resend, but faced some problems, and understand that I can't do it in time before soft-freeze..
>> But you say, that we can deprecate something even after hard-freeze?
>
> See above.
>
>> Ok, the problem that I faced, is that deprecation warnings breaks some iotests.. What can we do?
>>
>> 1. Update iotests...
>> 1.1 Just update iotests outputs to show warnings. Then, in next release cycle, update iotests, to not use deprecated things
>
> Sounds workable to me, but I'm not the maintainer.
>
>> or
>> 1.2 Update iotests to not use deprecated things.. Not appropriate for hard freeze.
>
> Unnecessarily risky compared to 1.1.
>
>> or
>> 2. Commit deprecations without warnings.. But how do people find out about this?
>
> Not nice.
>
> We do it for QMP, but only because we still lack the means to warn
> there.
>
>> Next, what exactly to deprecate? As I understand, we can't deprecate drive-mirror now?
>> So I propose to:
>>
>> 1. deprecate drive-backup
>> 2. add optional filter-node-name parameter to drive-mirror, to correspond to commit and mirror
>> 3. deprecate that filter-node-name is optional for commit and mirror.
>
> To have a chance there, we need patches a.s.a.p.
>
OK, I'll send today and we'll see, what to do with it.
--
Best regards,
Vladimir
next prev parent reply other threads:[~2019-11-08 9:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 10:07 [Qemu-devel] [PATCH 0/2] Deprecate implicit filters Vladimir Sementsov-Ogievskiy
2019-08-14 10:07 ` [Qemu-devel] [PATCH 1/2] qapi: deprecate drive-mirror and drive-backup Vladimir Sementsov-Ogievskiy
2019-08-14 19:22 ` John Snow
2019-08-15 7:44 ` [Qemu-devel] [libvirt] " Peter Krempa
2019-08-15 21:24 ` John Snow
2019-08-14 10:07 ` [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters Vladimir Sementsov-Ogievskiy
2019-08-14 19:27 ` John Snow
2019-08-14 20:34 ` [Qemu-devel] [Qemu-block] " Maxim Levitsky
2019-08-15 10:49 ` [Qemu-devel] " Kevin Wolf
2019-08-15 11:45 ` [Qemu-devel] [libvirt] " Peter Krempa
2019-08-15 14:04 ` Markus Armbruster
2019-08-29 16:45 ` Christophe de Dinechin
2019-08-29 17:57 ` John Snow
2019-08-30 10:07 ` Christophe de Dinechin
2019-08-30 18:11 ` John Snow
2019-09-02 12:04 ` Kevin Wolf
2019-11-22 8:41 ` Markus Armbruster
2019-11-22 11:32 ` Christophe de Dinechin
2019-08-15 16:07 ` [Qemu-devel] " John Snow
2019-08-15 16:48 ` Kevin Wolf
2019-08-15 17:33 ` John Snow
2019-08-15 19:24 ` Markus Armbruster
2019-08-16 8:20 ` Kevin Wolf
2019-08-16 12:33 ` Markus Armbruster
2019-08-16 12:58 ` Vladimir Sementsov-Ogievskiy
2019-08-15 14:16 ` [Qemu-devel] Exposing feature deprecation to machine clients (was: [PATCH 2/2] qapi: deprecate implicit filters) Markus Armbruster
2019-08-15 17:40 ` John Snow
2019-11-07 18:52 ` [Qemu-devel] Exposing feature deprecation to machine clients Philippe Mathieu-Daudé
2019-11-07 19:13 ` Vladimir Sementsov-Ogievskiy
2019-11-08 6:41 ` Deprecating stuff for 4.2 (was: [Qemu-devel] Exposing feature deprecation to machine clients) Markus Armbruster
2019-11-08 9:36 ` Vladimir Sementsov-Ogievskiy [this message]
2019-11-08 8:35 ` [Qemu-devel] Exposing feature deprecation to machine clients Max Reitz
2019-08-29 15:59 ` [Qemu-devel] [PATCH 2/2] qapi: deprecate implicit filters Christophe de Dinechin
2019-08-29 17:18 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-23 9:22 ` [Qemu-devel] " Vladimir Sementsov-Ogievskiy
2019-08-27 20:12 ` John Snow
2019-08-28 9:20 ` Vladimir Sementsov-Ogievskiy
2019-08-28 17:48 ` John Snow
2019-08-29 14:44 ` Peter Krempa
2019-08-29 15:17 ` Vladimir Sementsov-Ogievskiy
2019-08-29 17:50 ` John Snow
2019-08-29 15:00 ` Vladimir Sementsov-Ogievskiy
2019-08-29 15:16 ` Vladimir Sementsov-Ogievskiy
2019-09-02 12:14 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26371ed9-79ce-4d2a-e052-dca1310062b2@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).