From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C6C2C433DB for ; Tue, 9 Mar 2021 21:28:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC6676527D for ; Tue, 9 Mar 2021 21:28:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC6676527D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJju9-0006pk-NB for qemu-devel@archiver.kernel.org; Tue, 09 Mar 2021 16:28:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJjaU-0001h3-Gc; Tue, 09 Mar 2021 16:08:18 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:39073) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJjaR-0001At-Tl; Tue, 09 Mar 2021 16:08:18 -0500 Received: from [192.168.100.1] ([82.142.6.26]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.119]) with ESMTPSA (Nemesis) id 1N5G1T-1liWIA3JVl-0119Sl; Tue, 09 Mar 2021 22:08:03 +0100 Subject: Re: [PATCH] migration: Remove time_t cast for OpenBSD To: Thomas Huth , Brad Smith , qemu-devel@nongnu.org References: <7eaad721-9d2a-83ed-00fc-80c8ee37e156@redhat.com> From: Laurent Vivier Message-ID: <26c9c34a-3872-c044-4b01-06d2eb4bfbb1@vivier.eu> Date: Tue, 9 Mar 2021 22:08:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <7eaad721-9d2a-83ed-00fc-80c8ee37e156@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:ty1V12YAowO0ta6d48aN3YFy9pV+bZ+592T3WIJi/pYI0OBZrkU Wx5Sf3cah4ZfT8xVnjRW4Nq/fPJIwiR52k+W1BdLJpAFeytBSBB7TcPMilVRo59BxCfVUg4 1t7knKWo6OVdySrDmR6hkL3g4vqL4F89/LYQ32i8oXjucSkiAeMqsLRmTazJEgK98aIB4qP 7Zm9utfhIVhQGi3nEuSQA== X-UI-Out-Filterresults: notjunk:1;V03:K0:G9zRZDAt/58=:Updr2FDvNaBl4saYPMfjus 7xArot2t0fQBri/Km7B4lxSL2hXqQV7lShwzxY0/HH7eTHEJh1pf93bCuurbipS5PamF7UPBF qkRhKTXXN4lwxYSjrsaYb4n/L5Yrv9mQulcWr20nByZgucWuiIC1wR6Lstzg+DbM1ALfAUSWz IrvGTVh7bx6GNKoYWH07EnlX/ziG/SNHS/gtmmQ1bUIourJo6a2FiCb7nXpn8N27J7gnJzIKj L3DLF+IcYaRyAwLHGcJIx5+aJp7tkiwf622mXo9rTH+wmcWAZ8LH5zL88hAyMRA0axnDLyr9L xqALGm1N8Qt+Hqbnh66JQaTS/KdFbxFEf1cgfjDoUZQF1aH1E3xUDRkI34dwng4yPZYRL+vfq J/DatCrwvRcGgITU/qUit6dhdXSKC2r9ZqyVcPkM/IH1XzEhtcKNZzwDLEA8PNW/UnRpiszSj mnFjKOgUQw== Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , "Dr. David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 08/03/2021 à 12:46, Thomas Huth a écrit : > On 22/02/2021 08.28, Brad Smith wrote: >> OpenBSD has supported 64-bit time_t across all archs since 5.5 released in 2014. >> >> Remove a time_t cast that is no longer necessary. >> >> >> Signed-off-by: Brad Smith >> >> diff --git a/migration/savevm.c b/migration/savevm.c >> index 52e2d72e4b..9557f85ba9 100644 >> --- a/migration/savevm.c >> +++ b/migration/savevm.c >> @@ -2849,8 +2849,7 @@ bool save_snapshot(const char *name, bool overwrite, const char *vmstate, >>       if (name) { >>           pstrcpy(sn->name, sizeof(sn->name), name); >>       } else { >> -        /* cast below needed for OpenBSD where tv_sec is still 'long' */ >> -        localtime_r((const time_t *)&tv.tv_sec, &tm); >> +        localtime_r(&tv.tv_sec, &tm); >>           strftime(sn->name, sizeof(sn->name), "vm-%Y%m%d%H%M%S", &tm); >>       } > but the qemu_timeval from "include/sysemu/os-win32.h" still uses a long: is this file compiled for win32? Thanks, Laurent