From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06DC6C433B4 for ; Thu, 13 May 2021 11:48:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CF68610A0 for ; Thu, 13 May 2021 11:48:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CF68610A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=eldorado.org.br Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lh9p2-0008Jp-Fm for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 07:48:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lh9l4-000682-6W; Thu, 13 May 2021 07:44:02 -0400 Received: from [201.28.113.2] (port=33430 helo=outlook.eldorado.org.br) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lh9l2-0004YS-Bd; Thu, 13 May 2021 07:44:01 -0400 Received: from power9a ([10.10.71.235]) by outlook.eldorado.org.br with Microsoft SMTPSVC(8.5.9600.16384); Thu, 13 May 2021 08:43:56 -0300 Received: from [127.0.0.1] (unknown [10.10.70.45]) by power9a (Postfix) with ESMTP id D73A280139F; Thu, 13 May 2021 08:43:55 -0300 (-03) Subject: Re: [PATCH v4 28/31] target/ppc: Implement setbc/setbcr/stnbc/setnbcr instructions To: Richard Henderson , qemu-devel@nongnu.org, qemu-ppc@nongnu.org References: <20210512185441.3619828-1-matheus.ferst@eldorado.org.br> <20210512185441.3619828-29-matheus.ferst@eldorado.org.br> From: "Matheus K. Ferst" Message-ID: <271e1e13-478a-2a9c-958a-793ea6f2b3a5@eldorado.org.br> Date: Thu, 13 May 2021 08:43:55 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-OriginalArrivalTime: 13 May 2021 11:43:56.0274 (UTC) FILETIME=[41847520:01D747ED] X-Host-Lookup-Failed: Reverse DNS lookup failed for 201.28.113.2 (failed) Received-SPF: pass client-ip=201.28.113.2; envelope-from=matheus.ferst@eldorado.org.br; helo=outlook.eldorado.org.br X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lagarcia@br.ibm.com, bruno.larsen@eldorado.org.br, luis.pires@eldorado.org.br, f4bug@amsat.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 13/05/2021 08:01, Richard Henderson wrote: > On 5/12/21 1:54 PM, matheus.ferst@eldorado.org.br wrote: >> +static bool do_set_bool_cond(DisasContext *ctx, arg_X_bi *a, bool >> neg, bool rev) >> +{ >> +    REQUIRE_INSNS_FLAGS2(ctx, ISA310); >> +    uint32_t mask = 0x08 >> (a->bi & 0x03); >> +    TCGv temp = tcg_temp_new(); >> + >> +    tcg_gen_extu_i32_tl(temp, cpu_crf[a->bi >> 2]); >> +    tcg_gen_andi_tl(temp, temp, mask); >> +    tcg_gen_movcond_tl(a->r?TCG_COND_EQ:TCG_COND_NE, cpu_gpr[a->rt], >> temp, >> +                       tcg_constant_tl(0), tcg_constant_tl(a->n?-1:1), >> +                       tcg_constant_tl(0)); > > Mind the spacing around ?:. > Fixed. > Did you forget to update a->r and a->n to "neg" and "rev"? > It sure looks like this doesn't compile... > I messed up when rebasing, the change is in the next patch. I'll fix that too. > I guess this is fine with movcond, but perhaps slightly better with > >   tcg_gen_setcondi_tl(cond, rt, temp, 0); >   if (neg) { >     tcg_gen_neg_tl(rt, rt); >   } > > TCG isn't the most optimizing of compilers... > > > r~ And also looks cleaner, I'll apply that too. -- Matheus K. Ferst Instituto de Pesquisas ELDORADO Analista de Software Júnior Aviso Legal - Disclaimer