From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03D86C761A6 for ; Mon, 27 Mar 2023 18:11:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgrJ9-00029q-6V; Mon, 27 Mar 2023 14:11:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgrJ7-00029V-7v for qemu-devel@nongnu.org; Mon, 27 Mar 2023 14:11:02 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgrJ5-0007lk-O9 for qemu-devel@nongnu.org; Mon, 27 Mar 2023 14:11:00 -0400 Received: by mail-pj1-x102d.google.com with SMTP id gp15-20020a17090adf0f00b0023d1bbd9f9eso12667898pjb.0 for ; Mon, 27 Mar 2023 11:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679940658; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FyG8/kHuFLzlJCJ+7W6VUMb7LHSaP66RByXTP6tKQ9U=; b=DJitybBwNdtL7OpEifmbqrQKwtP/TPQpocdBJxyqYy7GRxzgdsmVn1z0xTNK9pZGxx h4JOOXbOnOxSVP3i36pVwj3jplVapJMebmIhdALZzzUp//j0mnvGRiVmjBj/8j+XY6nn 9oNQbSuCPMEk1R7I3xh+2irSXH3gi64rzVBsB9blktDyRn7hBfHcu6YIX+TS6rhT2QoO 3a3ycdujCTKE8Auz9uKySiytJv56FrLIaozUGBZo2/uH8/r15ZiptB58N9LBqshzJbZt 1Iwb4kmO6Qe93/IR9oP0GVa/5/wnzRkrmA0grGAoOpFaTRHm327Qu173Fz/7XmrbpEWn +74w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679940658; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FyG8/kHuFLzlJCJ+7W6VUMb7LHSaP66RByXTP6tKQ9U=; b=u8RMUB+vyzABjN/7+3LTfZbgAk68ckAcmLV/CPD3bufZyfpw36KFOdUb8xabDUsJvB AVJuDnTfDFKMt10N3uBV3UG7y1pvfftEvA3vYHcqTVkKjdGh0jNuAVGeQMpF1SK5Xiz8 AHOj+Jgm0WcHJxAYngmRnwhhZUYnLf64euR8yWu1HlXETko5Rp+khPkj7imLyBSxppi+ jXTwEY9Ba88Dptn9Y3vN99PlCcTjc/A04DzPIi3PljHcMFpe5aPBpJyVRk6NVc2qaT5A vwLckjD1F4Fsm7UCTgz/AqoINfCJLXBLcTHHx/LMxKltOqMNkk15HqUos3paDWDiWb5b f4cg== X-Gm-Message-State: AAQBX9eVTC8k0bCkxlvDVC9jsH6SyOSu4S3wNXR1KaM1ZUsQfY6cQmjs yioLabMyPYVpBh/qs1qEhsl3fg== X-Google-Smtp-Source: AKy350Yy+L+Z4Vo7ObX1zSE8+lEh0y4EcevZTqQNhusY1Rb+md80YOC/6vRRkYVOQvVLnStU1MkcQA== X-Received: by 2002:a17:902:ecc2:b0:19c:da68:337a with SMTP id a2-20020a170902ecc200b0019cda68337amr15976895plh.31.1679940658081; Mon, 27 Mar 2023 11:10:58 -0700 (PDT) Received: from ?IPV6:2602:ae:1544:6601:6705:aa17:3641:e634? ([2602:ae:1544:6601:6705:aa17:3641:e634]) by smtp.gmail.com with ESMTPSA id jf9-20020a170903268900b001967580f60fsm19468597plb.260.2023.03.27.11.10.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 11:10:57 -0700 (PDT) Message-ID: <27b4d21e-3e29-e0af-ac5f-47a84f36ff12@linaro.org> Date: Mon, 27 Mar 2023 11:10:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 06/10] target/riscv: Remove riscv_cpu_virt_enabled() Content-Language: en-US To: Weiwei Li , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, wangjunqiang@iscas.ac.cn, lazyparser@gmail.com References: <20230327080858.39703-1-liweiwei@iscas.ac.cn> <20230327080858.39703-7-liweiwei@iscas.ac.cn> From: Richard Henderson In-Reply-To: <20230327080858.39703-7-liweiwei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/27/23 01:08, Weiwei Li wrote: > Directly use env->virt_enabled instead. > > Suggested-by: LIU Zhiwei > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang > --- > target/riscv/cpu.c | 2 +- > target/riscv/cpu.h | 1 - > target/riscv/cpu_helper.c | 51 ++++++++++++++++++--------------------- > target/riscv/csr.c | 46 +++++++++++++++++------------------ > target/riscv/debug.c | 10 ++++---- > target/riscv/op_helper.c | 18 +++++++------- > target/riscv/pmu.c | 4 +-- > target/riscv/translate.c | 2 +- > 8 files changed, 64 insertions(+), 70 deletions(-) Reviewed-by: Richard Henderson r~